Avoid race conditions in tests #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows avoiding race conditions by using the 'listen' option to Test::TCP and passing the open socket to the server. Use this in Plack::Test::Server.
|
The Test::TCP change that this depends on has now been merged and released, so this could be too. |
|
You should rebuild travis CI test. |
miyagawa
added a commit
that referenced
this pull request
Mar 16, 2016
Avoid race conditions in tests
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
listen_sockoption to HTTP::Server::PSGI and uses this in combination with the newlistenoption toTest::TCP::test_tcp(see tokuhirom/Test-TCP#48) to avoid race conditions in the tests.