Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert hello.py to Python 3 #639

Merged
merged 2 commits into from Jul 18, 2019
Merged

Convert hello.py to Python 3 #639

merged 2 commits into from Jul 18, 2019

Conversation

eseyman
Copy link

@eseyman eseyman commented Jul 18, 2019

Support for Python 2 will end on 2020-01-01. Given this, it make sense to move t/Plack-Middleware/cgi-bin/hello.py to use Python 3 instead.

@miyagawa
Copy link
Member

how about adding from __future__ import print_function so that it will work with both python 2&3?

i'm ok with converting it to bash or something as well since that's not the point of this test.

@eseyman
Copy link
Author

eseyman commented Jul 18, 2019

how about adding from __future__ import print_function so that it will work with both python 2&3?

Done.

@miyagawa
Copy link
Member

Thanks!

@miyagawa miyagawa merged commit 08e6659 into plack:master Jul 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants