From 617bf3d51dd633071f01d4a208ae48cda0330821 Mon Sep 17 00:00:00 2001 From: Paolo Bernasconi Date: Fri, 27 Apr 2018 13:37:55 -0700 Subject: [PATCH 1/4] Add Assets as a product --- src/main/java/com/plaid/client/request/common/Product.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/com/plaid/client/request/common/Product.java b/src/main/java/com/plaid/client/request/common/Product.java index 9ee0f9af12..70cca6f0e2 100644 --- a/src/main/java/com/plaid/client/request/common/Product.java +++ b/src/main/java/com/plaid/client/request/common/Product.java @@ -3,6 +3,7 @@ import com.google.gson.annotations.SerializedName; public enum Product { + @SerializedName("assets") ASSETS, @SerializedName("balance") BALANCE, @SerializedName("credit_details") CREDIT_DETAILS, @SerializedName("income") INCOME, From f2ab5dfb7625fb92bbd04c014db1d5bc80e38f63 Mon Sep 17 00:00:00 2001 From: Paolo Bernasconi Date: Fri, 27 Apr 2018 13:45:07 -0700 Subject: [PATCH 2/4] Add assets to assertions --- .../com/plaid/client/integration/InstitutionsGetByIdTest.java | 2 +- .../java/com/plaid/client/integration/ItemCreateTest.java | 4 ++-- src/test/java/com/plaid/client/integration/ItemMfaTest.java | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/java/com/plaid/client/integration/InstitutionsGetByIdTest.java b/src/test/java/com/plaid/client/integration/InstitutionsGetByIdTest.java index 5953b18302..2a4d5032fc 100644 --- a/src/test/java/com/plaid/client/integration/InstitutionsGetByIdTest.java +++ b/src/test/java/com/plaid/client/integration/InstitutionsGetByIdTest.java @@ -31,7 +31,7 @@ public void testSuccess() throws Exception { assertEquals(TARTAN_BANK_INSTITUTION_ID, institution.getInstitutionId()); assertEquals(Arrays.asList("code", "list", "questions", "selections"), institution.getMfa()); assertEquals("Tartan Bank", institution.getName()); - assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.TRANSACTIONS, Product.CREDIT_DETAILS, Product.INCOME, Product.IDENTITY), + assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.TRANSACTIONS, Product.CREDIT_DETAILS, Product.INCOME, Product.IDENTITY), institution.getProducts()); } diff --git a/src/test/java/com/plaid/client/integration/ItemCreateTest.java b/src/test/java/com/plaid/client/integration/ItemCreateTest.java index a99b37db0d..0755b4a574 100644 --- a/src/test/java/com/plaid/client/integration/ItemCreateTest.java +++ b/src/test/java/com/plaid/client/integration/ItemCreateTest.java @@ -43,7 +43,7 @@ public void testItemCreateFullyLoadedRequestSuccess() throws Exception { assertTrue(response.body().isItemResponse()); assertFalse(response.body().isMfaResponse()); - assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), + assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), response.body().getItem().getAvailableProducts()); assertEquals(1, response.body().getItem().getBilledProducts().size()); assertEquals(Arrays.asList(Product.TRANSACTIONS), response.body().getItem().getBilledProducts()); @@ -158,7 +158,7 @@ public void testItemCreateWithCredentialsToken() throws Exception { assertFalse(response.body().isMfaResponse()); assertEquals(5, response.body().getItem().getAvailableProducts().size()); - assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), + assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), response.body().getItem().getAvailableProducts()); assertEquals(1, response.body().getItem().getBilledProducts().size()); assertEquals(Arrays.asList(Product.TRANSACTIONS), response.body().getItem().getBilledProducts()); diff --git a/src/test/java/com/plaid/client/integration/ItemMfaTest.java b/src/test/java/com/plaid/client/integration/ItemMfaTest.java index 5e7ba14c22..43cf3155fa 100644 --- a/src/test/java/com/plaid/client/integration/ItemMfaTest.java +++ b/src/test/java/com/plaid/client/integration/ItemMfaTest.java @@ -170,7 +170,7 @@ private static void assertItemResponse(Response itemCreateRe assertSuccessResponse(response); assertTrue(response.body().isItemResponse()); assertFalse(response.body().isMfaResponse()); - assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), + assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), response.body().getItem().getAvailableProducts()); assertEquals(1, response.body().getItem().getBilledProducts().size()); assertThat(response.body().getItem().getBilledProducts(), hasItems(Product.TRANSACTIONS)); From 881f397a1e79621f9bb5165dc6e0bdf57ed221ae Mon Sep 17 00:00:00 2001 From: Paolo Bernasconi Date: Fri, 27 Apr 2018 13:48:22 -0700 Subject: [PATCH 3/4] undo last fix --- src/test/java/com/plaid/client/integration/ItemCreateTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/com/plaid/client/integration/ItemCreateTest.java b/src/test/java/com/plaid/client/integration/ItemCreateTest.java index 0755b4a574..d90ae77aa6 100644 --- a/src/test/java/com/plaid/client/integration/ItemCreateTest.java +++ b/src/test/java/com/plaid/client/integration/ItemCreateTest.java @@ -158,7 +158,7 @@ public void testItemCreateWithCredentialsToken() throws Exception { assertFalse(response.body().isMfaResponse()); assertEquals(5, response.body().getItem().getAvailableProducts().size()); - assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), + assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), response.body().getItem().getAvailableProducts()); assertEquals(1, response.body().getItem().getBilledProducts().size()); assertEquals(Arrays.asList(Product.TRANSACTIONS), response.body().getItem().getBilledProducts()); From ffc6e9195fced0667bdc2ad2174cfc59a563a572 Mon Sep 17 00:00:00 2001 From: Paolo Bernasconi Date: Fri, 27 Apr 2018 13:51:21 -0700 Subject: [PATCH 4/4] eek should be 6 products --- .../java/com/plaid/client/integration/ItemCreateTest.java | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/test/java/com/plaid/client/integration/ItemCreateTest.java b/src/test/java/com/plaid/client/integration/ItemCreateTest.java index d90ae77aa6..544df0f39c 100644 --- a/src/test/java/com/plaid/client/integration/ItemCreateTest.java +++ b/src/test/java/com/plaid/client/integration/ItemCreateTest.java @@ -157,8 +157,8 @@ public void testItemCreateWithCredentialsToken() throws Exception { assertTrue(response.body().isItemResponse()); assertFalse(response.body().isMfaResponse()); - assertEquals(5, response.body().getItem().getAvailableProducts().size()); - assertEquals(Arrays.asList(Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), + assertEquals(6, response.body().getItem().getAvailableProducts().size()); + assertEquals(Arrays.asList(Product.ASSETS, Product.AUTH, Product.BALANCE, Product.CREDIT_DETAILS, Product.IDENTITY, Product.INCOME), response.body().getItem().getAvailableProducts()); assertEquals(1, response.body().getItem().getBilledProducts().size()); assertEquals(Arrays.asList(Product.TRANSACTIONS), response.body().getItem().getBilledProducts());