Skip to content
Permalink
Browse files

Spectre is touchy about things that die in perl. Fix the UpdateAssetS…

…ubscribers workflow activity to catch if the group in the asset does not exist.
  • Loading branch information...
perlDreamer committed Sep 17, 2012
1 parent 2aeca17 commit ca78e1db4ef1463bd223b348b031b8af007086f9
Showing with 7 additions and 1 deletion.
  1. +1 −0 docs/changelog/7.x.x.txt
  2. +6 −1 lib/WebGUI/Workflow/Activity/UpdateAssetSubscribers.pm
@@ -7,6 +7,7 @@
- fixed #12362: Thingy default Y/N field overly default
- fixed #12385: UTF-8 characters in Asset title break the Trash
- fixed ... and the same problem in the Clipboard
- fixed: UpdateAssetSubscribers workflow activity ERRORs if the group cannot be found.

7.10.26
- fixed: Template diagnostics when called without a session asset.
@@ -71,13 +71,18 @@ See WebGUI::Workflow::Activity::execute() for details.
sub execute {
my $self = shift;
my $asset = shift;
my $session = $self->session;

return unless $asset->get('subscriptionGroupId');

my $expireTime = time() + $self->getTTL();
my $subscriptionGroup = WebGUI::Group->new($self->session, $asset->get('subscriptionGroupId'));
my $subscriptionGroup = WebGUI::Group->new($session, $asset->get('subscriptionGroupId'));

##Deserialize from scratch
if (! $subscriptionGroup) {
$session->log->warn("Subscription group is missing for assetId: ".$asset->getId);
return $self->COMPLETE;
}
my @users = @{ $subscriptionGroup->getUsers }; ##Cache
my @usersToDelete = (); ##Cache
##Note, we could use grep here, but we can't interrupt if the workflow runs too long

0 comments on commit ca78e1d

Please sign in to comment.
You can’t perform that action at this time.