Skip to content
Commits on Jan 7, 2014
  1. @scrottie
Commits on Sep 27, 2013
  1. @scrottie
  2. @scrottie

    Revert "AdminToggle Macro is blank when in admin mode"

    apparently, $session->isAdminOn is meaningless in wG8.  this is a poor situation that it exists but is busted.  have to do this same thing another way.
    This reverts commit 1e22418.
    scrottie committed Sep 27, 2013
  3. @perlDreamer
  4. @daviddelikat
  5. @scrottie

    WebGUI::Asset->getHelpers entries specifiying a url field were breaki…

    …ng the Tree view when selected from the drop down.
    
    WebGUI.Admin.prototype.getHelperHandler was using gotoAsset(), which calls tree.goto(), which mangles the URL into being a request for
    the data needed to draw the Tree view of that asset, or tries to.  that works fine when navigating to an asset, but foo?func=edit is
    not an asset, and the mangled URL is garbled.  all of the urls (okay, the one attached to the 'edit' and 'view' entries) aren't
    trying to direct the admin to an asset but instead are trying to direct it to an admin screen, which, again, cannot be shown in the
    data table in Tree view.  so edit and view were fixed by changing that to instead do a showView(), which flops over to the View mode
    and then loads the URL without trying to mangle it.
    at this point, nothing is blowing up in Doug's JS admin when testing the asset helper menu items in View or Tree mode, though
    there are still some problems.
    scrottie committed Sep 27, 2013
  6. @scrottie

    change WebGUI.Admin.prototype.processPlugin, which handles messages b…

    …ack from calls to AssetHelper classes, to do any number of little chores according to the message contents rather than just the first one it tests for.
    
    change the Lock AssetHelper to both refresh and display a message indicating that the asset is locked.  the refresh is needed for tree view which displays a little icon.
    scrottie committed Sep 26, 2013
  7. @scrottie

    Save button in Export as HTML has bad style (#12424):

    Heh.  Actually, the save button is a YUI styled button, and it is perfectly rendered.  It also happens to have a background color exactly matching the dialog's background's.  Since these buttons are usually unstyled HTML buttons, I swapped the YUI one out for that.
    I also got distracted with the form rendering half way down the page and creeping down further as the hoverhelp tips come and go so I opened http://www.webgui.org/community/webgui-8/issues/12433 and then temporarily vanquished them in this form.
    scrottie committed Sep 26, 2013
  8. @scrottie
Commits on Sep 26, 2013
  1. @scrottie

    Create Shortcut - Admin bar clipboard display (#12432): all menu oper…

    …ations/AssetHelper calls now trigger a clipboard refresh
    scrottie committed Sep 26, 2013
  2. @scrottie
  3. @scrottie

    fix up Operation::User (op=editUser) some more for the new admin: giv…

    …e it Save and Cancel buttons, and template it into the style with $session->style->process() so that it gets the headers that it needs for pulling in YUI and stuff like that as well as so that it is styled to look nice.
    scrottie committed Sep 26, 2013
  4. @scrottie

    make Form::Cancel better; make WebGUI::TabForm use it. so, logic migr…

    …ated from TabForm to Form::Cancel where it's re-usable and fixed up for this new Doug admin.
    scrottie committed Sep 26, 2013
  5. @scrottie

    Create a Form::Cancel; FormBuilder doesn't automatically add Save/Can…

    …cel buttons so this can serve as a Cancel button for it; it attempts to correctly handle either closing the modal pop-up dialog or else going back in history/going back to the page that linked to this one. needs tests. the Cancel button in TabSet needs to use this logic.
    scrottie committed Sep 26, 2013
  6. @daviddelikat

    AdminToggle Macro is blank when in admin mode

    webgui 8 does not require a 'turn admin off' switch.
    daviddelikat committed Sep 25, 2013
Commits on Sep 25, 2013
  1. @scrottie

    finish the "Upload Files" implementation; the AssetHelper had some bu…

    …gs and needed to close the pop-up dialog that it created.
    scrottie committed Sep 25, 2013
  2. @scrottie

    $session->asset is not defined if we're running from a Content Handle…

    …r or the like. make reporting it conditional so that we don't get error output from our error output.
    scrottie committed Sep 24, 2013
  3. @scrottie

    don't reload the Tree/View pane after a Copy Branch operation; Copy B…

    …ranch doesn't mutate the asset tree being viewed so not needed
    scrottie committed Sep 24, 2013
  4. @scrottie

    refactor WebGUI.Admin.prototype.gotoAsset slightly to avoid code dupl…

    …ication
    
    WebGUI.Admin.prototype.addPasteHandler: guessing but fix use of 'this' vs 'self'
    currentTabName() to avoid code duplication for figuring out which context we're running in (Tree/View)
    WebGUI.Admin.prototype.pasteAsset:  handle pasting in the Tree view by flopping over to the View view first
    WebGUI.Admin.Tree.prototype.goto: better error handling/debugging
    added this FIXME to WebGUI.Admin.prototype.gotoAsset:
    a lot of Tree view operations fail after this point.  where the View version just directly goes to the URL, the Tree view tries to modify the URL to pass the extjs-st
    scrottie committed Sep 18, 2013
  5. @scrottie

    Revert "refactor WebGUI.Admin.prototype.gotoAsset slightly to avoid c…

    …ode duplication"
    
    ... oops, dead code may not be dead afterall
    
    This reverts commit aeb26ab.
    
    Conflicts:
    	www/extras/admin/admin.js
    scrottie committed Sep 18, 2013
  6. @scrottie

    Making the "Copy Branch" menu option work was a treat.

    requestHelper() invokes an asset helper via AJAX.  processPlugin() handles the JSON responses, which in this case is to open a dialog box and show
    a given URL in it (openDialog key in the JSON hash).  that pop-up is open and the page loaded, and that displays a form.  that form submits
    to an asset helper (uh oh) which also returns JSON (actually, it was failing to do even that and was stringifying a hash).  even if it returned
    JSON, it would just get shown to the user in the pop-up.  so the form that gets loaded into the pop-up has to, onsubmit, after it has config
    details from the user, run JS to make the AJAX request to the asset helper to start the actual copy operation, call into the admin's JS to
    pop up the dialog that polls on a forked process, and then call into the admin to close itself.  this is a nasty hack that daisy chains
    together two possible replies to processPlugin(), one after the other.
    scrottie committed Sep 18, 2013
  7. @perlDreamer @scrottie
  8. @scrottie

    WebGUI.Admin.prototype.reload: fix a lot of Tree view operations by d…

    …oing a this.tree.goto on location.pathname rather than href to drop incidental
    
    query parameters.  the view frame grows query parameters when it shows various edit and admin screens.
    add comments about safe/unsafe uses of goto with respect to Tree's URL mangling
    made updating the status message in the Fork progress dialog optional so the 'undefined' message should be gone now.
    scrottie committed Sep 18, 2013
  9. @perlDreamer @scrottie
  10. @perlDreamer @scrottie

    Fix label, remove debug.

    perlDreamer committed with scrottie Sep 18, 2013
  11. @perlDreamer @scrottie
  12. @perlDreamer @scrottie
  13. @perlDreamer @scrottie
  14. @perlDreamer @scrottie
  15. @perlDreamer @scrottie
Commits on Sep 24, 2013
  1. @scrottie

    don't let non-priviledged users turn on the admin; additional logic t…

    …o kick them out of admin when they're no longer logged in would be nice too.
    scrottie committed Sep 24, 2013
  2. @scrottie

    refactor WebGUI.Admin.prototype.gotoAsset slightly to avoid code dupl…

    …ication
    
    WebGUI.Admin.prototype.addPasteHandler: guessing but fix use of 'this' vs 'self'
    currentTabName() to avoid code duplication for figuring out which context we're running in (Tree/View)
    WebGUI.Admin.prototype.pasteAsset:  handle pasting in the Tree view by flopping over to the View view first
    removed WebGUI.Admin.Tree.prototype.runHelperForSelected and relatedly WebGUI.Admin.Tree.prototype.cut, copy, shortcut, duplicate, delete; these are dead code
    WebGUI.Admin.Tree.prototype.goto: better error handling/debugging
    added this FIXME to WebGUI.Admin.prototype.gotoAsset:
    a lot of Tree view operations fail after this point.  where the View version just directly goes to the URL, the Tree view tries to modify the URL to pass the extjs-style grid's parameters back.  this winds up creating unworkable URLs that try to do two things at once, with two '?'s, two 'op='s, etc.  there are two ways to fix this:  if we're trying to go to an asset (gotoAsset) and we're in Tree view, flop back to View mode first; or else two distinct requests, one for the remote request (which might generate additional requests to draw in dialog boxes, progress bars, forms, etc) and then when that's all done, refresh the grid view.  WebGUI.Admin.prototype.pasteAsset takes the route of flopping to Tree view first.
    scrottie committed Sep 17, 2013
  3. @scrottie

    the 'cut' drop down (AssetHelper) operation basically worked, but the…

    … screen wasn't redrawn after the change, and the JSON returned during Fork polling in WebGUI::AssetHelper::Cut didn't match what the YAHOO.WebGUI.Fork.poll callback in WebGUI.Admin.prototype.openForkDialog was expecting so status communication had to be wired up. wG::ProgressTree exposes 'flat' now too for the sake of computing a progress bar. looking at only the roots nodes is ineffective; in this case, the number of root nodes would only ever be 1 though the number of child nodes to be processed could be much higher. WebGUI.Admin.prototype.openForkDialog's callback to YAHOO.WebGUI.Fork.poll handles a status JSON message (JSON inside of JSON, ugh) of "reload" and there's an admin.reload() method now. that's also callable from WebGUI.Admin.prototype.processPlugin and was done in the style of its handlers.
    scrottie committed Sep 13, 2013
Commits on Sep 16, 2013
  1. @perlDreamer
Commits on Sep 13, 2013
  1. @perlDreamer
Something went wrong with that request. Please try again.