Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Server calendar in Online Activity Overview Network page shows incorrect data #1239

Open
ipozow opened this issue Dec 2, 2019 · 11 comments
Open
Labels
Bug

Comments

@ipozow
Copy link

@ipozow ipozow commented Dec 2, 2019

Describe the issue

The data shown in Server calendar it's delayed a day.
For example, in Sunday I had 418 unique players and 112 new players Captura de Pantalla 2019-12-02 a la(s) 09 15 17
and it says that Saturday I had 112 new players and 418 unique
Captura de Pantalla 2019-12-02 a la(s) 09 34 38
but that happened Sunday, not Saturday.
Today is Monday and it says that what is happening today happened Sunday (as it shows the image)

Another image for a better understanding:
Captura de Pantalla 2019-12-02 a la(s) 09 29 39

Server information

I have multiple server version, one is 1.14.4 and the other 1.13.2 paper 637 and in both is the same issue. I'm running a network too, Waterfall.

Server Information

Plan Version: 5.0 build 292
Server: BungeeCord git:Waterfall-Bootstrap:1.14-SNAPSHOT:cccb337:296 (git:Waterfall-Bootstrap:1.14-SNAPSHOT:cccb337:296)
Database: MySQL

Operating SubSystem: Linux (amd64) version 4.9.33-mod-std-ipv6-64
Java Version: 1.8.0_212, Oracle Corporation
Java VM Version: OpenJDK 64-Bit Server VM version 25.212-b03, Oracle Corporation

Exceptions & Other Logs

Additional information

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 2, 2019

What timezone is your server using?

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 2, 2019

Do the /server pages have the same issue?

@ipozow

This comment has been minimized.

Copy link
Author

@ipozow ipozow commented Dec 2, 2019

Actually these were the /server pages
And timezone is GMT-5

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 2, 2019

Are the other dates correct (Today Yesterday etc?) - Could you include a screenshot of the full calendar and 25 players from Player list tab sorted by most recent register date (I only need the register dates, no need for other columns)

@ipozow

This comment has been minimized.

Copy link
Author

@ipozow ipozow commented Dec 2, 2019

Captura de Pantalla 2019-12-02 a la(s) 11 23 07

Captura de Pantalla 2019-12-02 a la(s) 11 22 35

Captura de Pantalla 2019-12-02 a la(s) 11 24 44

Captura de Pantalla 2019-12-02 a la(s) 11 27 49

And no, the other dates aren't correct. They are delayed one day too

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 2, 2019

It looks like the issue is limited to the calendar and the graph and other times are correct, while calendar is delayed by one day.

There is likely some logic mistake that is related to negative timezone offset that causes the days to be grouped on the previous day, I'll take a look at it when I have the time

@Rsl1122 Rsl1122 added the Bug label Dec 2, 2019
@Rsl1122 Rsl1122 added this to Backlog (HIGH Priority) in Active Development Dec 2, 2019
@Rsl1122 Rsl1122 moved this from Backlog (HIGH Priority) to Current Cycle in Active Development Dec 4, 2019
@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 4, 2019

I found out the cause of the issue and why it doesn't occur with GMT +X timezones

Where Applied Offset Description
In Database +0 Stored as UTC
In query -5 to group,, output as UTC 0 AM milliseconds
To Graph JSON +0 output as UTC 0 AM milliseconds
To Calendar JSON -5 (-10 total) Applies timezone offset (Second time) while formatting milliseconds to ISO-8601 (Calendar wants this), causing the date to roll to the wrong day

In GMT +12 formatting to ISO-8601 (yyyy-MM-dd) does not roll to the next day, but in -1 it does roll to the previous day

@Rsl1122 Rsl1122 closed this in cbcd2c7 Dec 4, 2019
Active Development automation moved this from Current Cycle to Finished (Current Sprint) Dec 4, 2019
@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 4, 2019

Here is a build with the fix done above: Plan-5.0 build 293.jar.zip

I want to do some other stuff before full release.

@ipozow

This comment has been minimized.

Copy link
Author

@ipozow ipozow commented Dec 24, 2019

This is still present in 335 :(

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 24, 2019

Could you send new screenshots

@ipozow

This comment has been minimized.

Copy link
Author

@ipozow ipozow commented Dec 24, 2019

Yes
Captura de Pantalla 2019-12-24 a la(s) 11 56 18

Captura de Pantalla 2019-12-24 a la(s) 11 55 45

@Rsl1122 Rsl1122 reopened this Dec 24, 2019
@Rsl1122 Rsl1122 removed this from Finished (Current Sprint) in Active Development Jan 29, 2020
@Rsl1122 Rsl1122 added this to Backlog (HIGH Priority) in Active Development Jan 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Active Development
  
Backlog (HIGH Priority)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.