Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak #1265

Open
iLemon opened this issue Dec 24, 2019 · 8 comments
Open

Memory leak #1265

iLemon opened this issue Dec 24, 2019 · 8 comments

Comments

@iLemon
Copy link

@iLemon iLemon commented Dec 24, 2019

Describe the issue

There's a memory leak caused by Plan on one of my paper 1.12 servers.

Server information

Proxy:
Plan Version: 5.0 build 335
Server: BungeeCord git:Travertine-Bootstrap:1.15-SNAPSHOT:61be17f:115 (git:Travertine-Bootstrap:1.15-SNAPSHOT:61be17f:115)
Database: MySQL

Operating SubSystem: Linux (amd64) version 4.15.0-70-generic
Java Version: 1.8.0_232, Private Build
Java VM Version: OpenJDK 64-Bit Server VM version 25.232-b09, Private Build

Server with memory leak:
This server is running CraftBukkit version git-Spigot-dcd1643-e60fc34 (MC: 1.12.2) (Implementing API version 1.12.2-R0.1-SNAPSHOT)

Here is the heap: https://i.imgur.com/yD0NmBN.png

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 24, 2019

Please send a list of enabled extensions in Plan config under Plugins (of the affected server)

@iLemon

This comment has been minimized.

Copy link
Author

@iLemon iLemon commented Dec 24, 2019

Plugins:
    ASkyBlock:
        Enabled: true
    Buycraft:
        # http://help.buycraft.net/article/36-where-to-find-the-secret-key
        Secret: '-'
    Economy (Vault):
        Enabled: true
    Essentials:
        Enabled: true
    Factions:
        HideFactions:
          - ExampleFaction
    GriefPrevention:
        Enabled: true
    Jobs:
        Enabled: true
    ProtocolSupport:
        Enabled: true
    SuperbVote:
        Enabled: true
    Towny:
        HideTowns:
          - ExampleTown
    ViaVersion:
        Enabled: true
    mcMMO:
        Enabled: true
    nuVotifier:
        Enabled: true
@iLemon

This comment has been minimized.

Copy link
Author

@iLemon iLemon commented Dec 24, 2019

Just noticed that since I copied the config to all servers (10), those plugins are for our Skyblock server but the issue is happening on a Prison server.

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Dec 24, 2019

Alright, I don't see any memory-leak suspect data on that extension list.


Are there any differences between the prison server and other servers? (eg are the other servers closer to the MySQL server, or are there a vast amount more players on this server for example)

I think the ThreadPool in question is the Transaction execution thread pool, which is a single thread that processes all database transactions. If more transactions are added than what it can process then that could lead to it getting overwhelmed (increasing amount of waiting transactions uncontrollably).

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Jan 17, 2020

One memory leak was discovered in Html Export - was export enabled on the Prison server?

@iLemon

This comment has been minimized.

Copy link
Author

@iLemon iLemon commented Jan 17, 2020

One memory leak was discovered in Html Export - was export enabled on the Prison server?

Is it enabled by default? If so, yes. If not, no.

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Jan 17, 2020

Not enabled by default

@Rsl1122

This comment has been minimized.

Copy link
Collaborator

@Rsl1122 Rsl1122 commented Jan 30, 2020

I just got an idea on how to try reproducing this. I'll report results after I've done so (Just writing this down here as a note for myself so that I don't forget it).

  • Add a Transaction that sleeps a long time (simulates mysql being very busy)
  • See what happens
    • Add some debug stuff to see how many items are in the transaction queue
  • Figure out if it is possible to swap to "Skip unnecessary transactions"-mode while running
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Active Development
  
Backlog (HIGH Priority)
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants
You can’t perform that action at this time.