Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser back button should go back to the previous page #1318

Closed
AuroraLS3 opened this issue Feb 2, 2020 · 1 comment · Fixed by #1617
Closed

Browser back button should go back to the previous page #1318

AuroraLS3 opened this issue Feb 2, 2020 · 1 comment · Fixed by #1617
Labels
Improvement Issues that suggest enhancing a feature or functionality further JavaScript & HTML Issues that are related to JavaScript or HTML of the plugin p: 5 Story points estimate for work required for implementing this issue

Comments

@AuroraLS3
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

Back button behavior was changed in 5.0 to go back to the previous tab.
This can lead to the following usability problem:

  • A player page is opened from /players page
  • The user views multiple different tabs
  • Wants to go back to /players page
  • Back button needs to be pressed many times, and the page does not have a direct link to the players page

I would like to be able to..

Restore previous behavior where tab navigation is not stored in history (but the address still stores information about the tab which is open)

@AuroraLS3 AuroraLS3 added Improvement Issues that suggest enhancing a feature or functionality further JavaScript & HTML Issues that are related to JavaScript or HTML of the plugin labels Feb 2, 2020
@AuroraLS3 AuroraLS3 added this to Current Cycle in Active Development Feb 4, 2020
@AuroraLS3 AuroraLS3 added the p: 5 Story points estimate for work required for implementing this issue label Feb 7, 2020
@AuroraLS3
Copy link
Collaborator Author

This behavior can be achieved by using window.location.replace and preventing default behavior of the a element.

Current implementation uses hashchange event with is triggered by the default behavior, which might lead to problems when re-implementing the behavior of the default event. - The default behavior needs to override the clickevent of the navigation links

@AuroraLS3 AuroraLS3 moved this from Current Cycle to Backlog (HIGH Priority) in Active Development Mar 13, 2020
@AuroraLS3 AuroraLS3 moved this from Backlog (HIGH Priority) to Current Cycle in Active Development Mar 13, 2020
@AuroraLS3 AuroraLS3 added this to Priority HIGH in Backlog (New features) Mar 31, 2020
Backlog (New features) automation moved this from Priority HIGH to Done Oct 19, 2020
AuroraLS3 pushed a commit that referenced this issue Oct 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Improvement Issues that suggest enhancing a feature or functionality further JavaScript & HTML Issues that are related to JavaScript or HTML of the plugin p: 5 Story points estimate for work required for implementing this issue
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

1 participant