Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Browser back button should go back to the previous page #1318

Open
Rsl1122 opened this issue Feb 2, 2020 · 1 comment
Open

Browser back button should go back to the previous page #1318

Rsl1122 opened this issue Feb 2, 2020 · 1 comment

Comments

@Rsl1122
Copy link
Collaborator

@Rsl1122 Rsl1122 commented Feb 2, 2020

Is your feature request related to a problem? Please describe.

Back button behavior was changed in 5.0 to go back to the previous tab.
This can lead to the following usability problem:

  • A player page is opened from /players page
  • The user views multiple different tabs
  • Wants to go back to /players page
  • Back button needs to be pressed many times, and the page does not have a direct link to the players page

I would like to be able to..

Restore previous behavior where tab navigation is not stored in history (but the address still stores information about the tab which is open)

@Rsl1122 Rsl1122 added this to Current Cycle in Active Development Feb 4, 2020
@Rsl1122 Rsl1122 added the p: 5 label Feb 7, 2020
@Rsl1122

This comment has been minimized.

Copy link
Collaborator Author

@Rsl1122 Rsl1122 commented Feb 7, 2020

This behavior can be achieved by using window.location.replace and preventing default behavior of the a element.

Current implementation uses hashchange event with is triggered by the default behavior, which might lead to problems when re-implementing the behavior of the default event. - The default behavior needs to override the clickevent of the navigation links

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Active Development
  
Current Cycle
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.