Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Action badge and link #34

Merged
merged 1 commit into from Oct 1, 2019
Merged

Fix GitHub Action badge and link #34

merged 1 commit into from Oct 1, 2019

Conversation

item4
Copy link
Contributor

@item4 item4 commented Oct 1, 2019

fix #31

@CLAassistant
Copy link

CLAassistant commented Oct 1, 2019

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@dahlia dahlia left a comment

This Markdown seems to break. Could you double-check the rendered result, please?

@item4
Copy link
Contributor Author

item4 commented Oct 1, 2019

@dahlia oh, it was my fault because i did not check syntax and fill URL only. i fix juxt now

Copy link
Member

@dahlia dahlia left a comment

Sorry, but could you adjust this so that it utilizes Markdown's reference definitions (as it had been until now)? Please look at the 9th and 10th lines.

dahlia
dahlia approved these changes Oct 1, 2019
@dahlia
Copy link
Member

dahlia commented Oct 1, 2019

@item4 Thanks four your contribution! Please sign our contributor license agreement as well.

moreal
moreal approved these changes Oct 1, 2019
@longfin longfin merged commit b9b67c7 into planetarium:master Oct 1, 2019
1 of 2 checks passed
@dahlia
Copy link
Member

dahlia commented Oct 2, 2019

@item4 Could you sign our CLA?

@item4
Copy link
Contributor Author

item4 commented Oct 2, 2019

@dahlia done it now

@dahlia
Copy link
Member

dahlia commented Oct 2, 2019

@item4 Thank you! 👍

MaxStalker added a commit to MaxStalker/libplanet-explorer-frontend that referenced this issue Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants