Skip to content
Permalink
Browse files

Apply suggestions from code review

Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>
  • Loading branch information
moreal and dahlia committed Feb 12, 2020
1 parent ed1a88a commit 60d3e2340370eb05df94ad6d489e31b67e29d724
Showing with 4 additions and 5 deletions.
  1. +4 −5 CHANGES.md
@@ -24,18 +24,17 @@ To be released.
### Behavioral changes

- `BlockChain.MineBlock()` method became to ignore transactions having
lower nonce than expected nonce in the chain. [[#791]]
lower nonce than the expected nonce in the chain. [[#791]]

### Bug fixes

- `Swarm<T>` became not to sync the same `Block<T>`s or `Transaction<T>`s
multiple times. [[#784]]
- Fixed a `Swarm<T>`'s bug that had broadcasted a message to its source peer when
the number of peers is not enough (less than the minimum number). [[#788]]
- Fixed a bug where `BlockChain.MineBlock()` couldn't mine valid block
if there was staged transaction which, has lower nonce than expected nonce,
in other word, has same nonce with transactions which signed by
same signer and already included. [[#791]]
- Fixed a bug where `BlockChain.MineBlock()` had produced an invalid block
when there is any staged transaction which has lower nonce than the expected nonce,
that means, shares an already taken nonce by the same signer. [[#791]]

[#784]: https://github.com/planetarium/libplanet/pull/784
[#785]: https://github.com/planetarium/libplanet/pull/785

0 comments on commit 60d3e23

Please sign in to comment.
You can’t perform that action at this time.