Skip to content
Permalink
Browse files

Remove temporary suppressors on S1128

SonarAnalyzer.CSharp's recent version fixed the bug
SonarSource/sonar-dotnet#2694

[changelog skip]
  • Loading branch information
dahlia committed Dec 18, 2019
1 parent 59fd941 commit f8dead3b5913551abc85ffadeafc0524b4688577
@@ -33,7 +33,7 @@
<PrivateAssets>all</PrivateAssets>
</PackageReference>
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.0" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.0.0.9566">
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.1.0.13383">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -31,7 +31,7 @@
runtime; build; native; contentfiles; analyzers; buildtransitive
</IncludeAssets>
</PackageReference>
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.0.0.9566">
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.1.0.13383">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -39,7 +39,7 @@
<PackageReference Include="Microsoft.NET.Test.Sdk" Version="16.1.0" />
<PackageReference Include="Serilog.Enrichers.Thread" Version="3.0.0" />
<PackageReference Include="Serilog.Sinks.XUnit" Version="1.0.7" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.0.0.9566">
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.1.0.13383">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -3,10 +3,8 @@
using System.Collections.Immutable;
using System.Linq;
using System.Security.Cryptography;
#pragma warning disable S1128 // Remove this unnecessary 'using'
using Libplanet.Blockchain.Policies;
using Libplanet.Blocks;
#pragma warning restore S1128 // Remove this unnecessary 'using'
using Libplanet.Tx;

namespace Libplanet.Action
@@ -1,6 +1,4 @@
#pragma warning disable S1128 // Remove this unnecessary 'using'
using System;
#pragma warning restore S1128 // Remove this unnecessary 'using'

namespace Libplanet.Action
{
@@ -1,9 +1,7 @@
using System;
using System.Security.Cryptography;
#pragma warning disable S1128 // Remove this unnecessary 'using'
using Libplanet.Blockchain.Policies;
using Libplanet.Blocks;
#pragma warning restore S1128 // Remove this unnecessary 'using'
using Libplanet.Tx;

namespace Libplanet.Action
@@ -1,8 +1,6 @@
using System;
using System.Security.Cryptography;
#pragma warning disable S1128
using Libplanet.Blocks;
#pragma warning restore S1128

namespace Libplanet.Blockchain
{
@@ -1,9 +1,7 @@
using System.Diagnostics.Contracts;
using System.Security.Cryptography;
#pragma warning disable S1128 // Remove this unnecessary 'using'
using Libplanet.Blockchain;
using Libplanet.Store;
#pragma warning restore S1128 // Remove this unnecessary 'using'

namespace Libplanet.Blocks
{
@@ -88,7 +88,7 @@ https://docs.libplanet.io/</Description>
<PackageReference Include="Planetarium.NetMQ" Version="4.0.0.260-planetarium" />
<PackageReference Include="Nito.AsyncEx" Version="5.0.0" />
<PackageReference Include="Serilog" Version="2.8.0" />
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.0.0.9566">
<PackageReference Include="SonarAnalyzer.CSharp" Version="8.1.0.13383">
<IncludeAssets>runtime; build; native; contentfiles; analyzers</IncludeAssets>
<PrivateAssets>all</PrivateAssets>
</PackageReference>
@@ -1,7 +1,5 @@
using System;
#pragma warning disable S1128 // Remove this unnecessary 'using'
using System.Collections.Immutable;
#pragma warning restore S1128 // Remove this unnecessary 'using'
using System.Linq;
using System.Security.Cryptography;
using Libplanet.Action;
@@ -1,8 +1,6 @@
using System;
using System.Diagnostics.CodeAnalysis;
#pragma warning disable S1128 // Remove this unnecessary 'using'
using Libplanet.Blockchain;
#pragma warning restore S1128 // Remove this unnecessary 'using'

namespace Libplanet.Tx
{

0 comments on commit f8dead3

Please sign in to comment.
You can’t perform that action at this time.