Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of Peer.Urls to IPEndPoint #120

Closed
longfin opened this issue Mar 8, 2019 · 1 comment

Comments

Projects
2 participants
@longfin
Copy link
Member

commented Mar 8, 2019

We've chosen Uri as element type of Peer.Urls to represent peer's address. but Uri isn't appropriate type because it also contains information that we do not need. (e.g. path, protocol)

So, I suggest IPEndPoint to peer's endpoint type. it has only IP address and port.

@ipdae

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

i'll try this issue.

@longfin longfin moved this from To do to In progress in comuka-20190309 Mar 9, 2019

@dahlia dahlia closed this in #123 Mar 9, 2019

comuka-20190309 automation moved this from In progress to Done Mar 9, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.