Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions thrown by actions during rehearsal mode should be wrapped #132

Closed
dahlia opened this issue Mar 19, 2019 · 0 comments

Comments

Projects
None yet
1 participant
@dahlia
Copy link
Member

commented Mar 19, 2019

As I explained in the issue #131, rehearsal mode tends to lead an action to reach an unexpected case. To a library user, it is likely to seem like it's their fault (I mean, it looks like the action won't work without rehearsal mode too, which is not necessarily so).

So that users can distinguishes errors due to rehearsal mode from other general errors, exceptions thrown by actions during that mode should be wrapped, like UnexpectedlyTerminatedTxRehearsalException with an inner exception.

@dahlia dahlia added the suggestion label Mar 19, 2019

@dahlia dahlia added this to the 0.2.0 milestone Mar 19, 2019

@dahlia dahlia self-assigned this Mar 19, 2019

dahlia added a commit to dahlia/libplanet that referenced this issue Mar 20, 2019

@dahlia dahlia closed this in f015490 Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.