Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exceptions should be public too if it's thrown by any public interface #133

Closed
longfin opened this issue Mar 20, 2019 · 0 comments

Comments

1 participant
@longfin
Copy link
Member

commented Mar 20, 2019

Currently, some exposed public APIs (e.g., BlockPolicy.ValidateBlocks()) return or throw non-public exception (e.g., InvalidBlockTimestampException).

If there is any public APIs that throw an exception that exception also should be the same visibility so that library users can catch them.

@longfin longfin changed the title Fix inconsistent protection about Exception Fix inconsistent protection level about Exception Mar 20, 2019

@longfin longfin changed the title Fix inconsistent protection level about Exception Fix inconsistent protection level about exception Mar 20, 2019

@longfin longfin added this to To do in comuka-20190320 Mar 20, 2019

@dahlia dahlia changed the title Fix inconsistent protection level about exception Exceptions should be public too if it's thrown by any public interface Mar 20, 2019

@longfin longfin added this to To do in comuka-20190406 Apr 6, 2019

@longfin longfin added this to To do in SprintSeoul-20190420 Apr 17, 2019

@longfin longfin closed this in #251 May 21, 2019

longfin added a commit that referenced this issue May 21, 2019

Merge pull request #251 from moreal/make-execeptions-public-133
Update access modifier of exception to public, resolve #133
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.