Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MinerAddress to ActionContext #173

Closed
earlbread opened this issue Apr 4, 2019 · 5 comments

Comments

Projects
None yet
2 participants
@earlbread
Copy link
Member

commented Apr 4, 2019

Currently, since there is no miner information in the ActionContext, there is no way to know who is a miner.

@earlbread earlbread self-assigned this Apr 4, 2019

@dahlia

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

What name would be appropriate for this property?

  • BlockMinerAddress
  • BlockMiner
  • MinerAddress
  • Miner
@earlbread

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

How about Miner? Because there is Signer already.

@dahlia

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

Because there is Signer already.

Since there's no property like Block<T>.Signature the term “signer” seems inappropriate for blocks.

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Apr 4, 2019

But ActionContext properies are:

public Address Signer { get; }
public long BlockIndex { get; }
public bool Rehearsal { get; }
public IAccountStateDelta PreviousStates { get; }
public IRandom Random { get; }

I thought it would be appropriate to add public Address Miner below Signer.
What do you think is appropriate?

@dahlia

This comment has been minimized.

Copy link
Member

commented Apr 4, 2019

For consistency, Miner without any prefix/suffix seems good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.