Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BlockChain raises KeyNotFoundException when index is not in it #208

Closed
ipdae opened this issue Apr 17, 2019 · 1 comment

Comments

Projects
3 participants
@ipdae
Copy link
Member

commented Apr 17, 2019

If there is no value at index when BlockChain[index] is called, ArgumentOutofRangeException should occur.
But it raises KeyNotFoundException, because Store.IndexBlockHash returns default(T) instead of null.

image (4)

@dahlia dahlia changed the title Raise `KeyNotFoundException` when index is not in `BlockChain` BlockChain raises KeyNotFoundException when index is not in it Apr 17, 2019

@dahlia dahlia added the bug label Apr 17, 2019

@ipdae ipdae moved this from To do to Review in progress in 스프린트서울 201906 Jun 29, 2019

@ipdae ipdae moved this from Review in progress to Reviewer approved in 스프린트서울 201906 Jun 29, 2019

@longfin longfin moved this from Reviewer approved to Done in 스프린트서울 201906 Jun 29, 2019

@longfin

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

it was resolved by #317

@longfin longfin closed this Jul 2, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.