Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the concept of “chain IDs” #279

Closed
dahlia opened this issue Jun 10, 2019 · 0 comments

Comments

Projects
None yet
2 participants
@dahlia
Copy link
Member

commented Jun 10, 2019

Currently game apps that use Libplanet have to remember both of the path of FileStore and the major chain ID (which is a UUID type). This current interface makes the implementation details (of how it distinguishes major/stale chains under the hood) hard to change in the future. It's also cumbersome for library users because they need to store two interdependent data.

So I suggest to change BlockChain to hide the concept of “chain IDs” and automatically choose the major chain by itself. This would improve both forward compatibility and usability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.