Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct GetBlockHashes chunk size after first phase #408

Closed
earlbread opened this issue Aug 7, 2019 · 1 comment · Fixed by #445

Comments

@earlbread
Copy link
Member

commented Aug 7, 2019

When a node received GetBlockHashes message, it sends block hashes as many asFindNextHashesChunkSize. However, after the first step, it seems to send block hashes as many as FindNextHashesChunkSize - 1:

When there are 2000 blocks to send,

  • Expected : 500, 500, 500, 500
  • Actual : 500, 499, 499, 499, 3
@gurrpi

This comment has been minimized.

Copy link
Contributor

commented Aug 15, 2019

I think I could solve this issue in PyCon Sprint today.

@longfin longfin assigned longfin and gurrpi and unassigned longfin Aug 16, 2019

@longfin longfin closed this in #445 Aug 17, 2019

PyCon Korea 2019 automation moved this from To do to Done Aug 17, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
3 participants
You can’t perform that action at this time.