Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore BlockHashes or TxIds which already stored #461

Closed
longfin opened this issue Aug 27, 2019 · 2 comments · Fixed by #484

Comments

@longfin
Copy link
Member

commented Aug 27, 2019

By current implementation, when Swarm<T> received TxIds or BlockHashes from other peers, it will try to receive payload even if it already has that transaction or block.

@longfin longfin added the bug label Aug 27, 2019
@limebell

This comment has been minimized.

Copy link
Contributor

commented Sep 2, 2019

I think Swarm<T> now ignores TxIds which are staged. Do you mean by the transactions that are already contained in blocks?

@longfin

This comment has been minimized.

Copy link
Member Author

commented Sep 2, 2019

I think Swarm<T> now ignores TxIds which are staged. Do you mean by the transactions that are already contained in blocks?

Nope, I've missed that Swarm<T>.ProcessTxIds() already ignores TxIds which are staged.

but Swarm<T>.ProcessBlockHashes is still trying to receive without check. so we should fix it as like as ProcessTxIds()

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.