Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename “maxValue” parameters in IRandom.Next() methods #555

Closed
dahlia opened this issue Oct 1, 2019 · 3 comments
Closed

Rename “maxValue” parameters in IRandom.Next() methods #555

dahlia opened this issue Oct 1, 2019 · 3 comments

Comments

@dahlia
Copy link
Member

@dahlia dahlia commented Oct 1, 2019

The IRandom.Next(int minValue, int maxValue) and IRandom.Next(int maxValue) methods never return maxValue but only values less than it. So the word “max” could mislead users. I suggest to find a more concise word to indicate that a number is chosen in a half-open interval.

@dahlia dahlia added this to the 0.7.0 milestone Oct 1, 2019
@dahlia dahlia changed the title Rename maxValue parameters in IRandom.Next() methods Rename “maxValue” parameters in IRandom.Next() methods Oct 1, 2019
@pBouillon
Copy link
Contributor

@pBouillon pBouillon commented Oct 1, 2019

Hi ! May I take this issue ? I would suggest IRandom.Next(int lowerBound, int upperBound) (along with a propper XML documentation)

@dahlia
Copy link
Member Author

@dahlia dahlia commented Oct 1, 2019

@pBouillon
Copy link
Contributor

@pBouillon pBouillon commented Oct 1, 2019

Awesome !
I'm on it then !

dahlia added a commit that referenced this issue Oct 1, 2019
Rename variable according to #555
@dahlia dahlia closed this Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants