Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swarm<T>'s events should be internal #705

Closed
moreal opened this issue Dec 4, 2019 · 2 comments
Closed

Swarm<T>'s events should be internal #705

moreal opened this issue Dec 4, 2019 · 2 comments

Comments

@moreal
Copy link
Contributor

@moreal moreal commented Dec 4, 2019

Currently, some exposed public events in Swarm<T> (i.e. TxReceived, BlockReceived) can be used from anyone. But it's to allow you to control the part of the low level logic. So they should be hidden from users by being private or internal. But in unit test, they are needed to access. Therefore, IMO they should be, internal.

@Oaroomy

This comment has been minimized.

Copy link
Contributor

@Oaroomy Oaroomy commented Dec 14, 2019

I'm going to work on this.

@moreal

This comment has been minimized.

Copy link
Contributor Author

@moreal moreal commented Dec 14, 2019

I believe it's resolved by #725.

@moreal moreal closed this Dec 14, 2019
스프린트서울 201912 automation moved this from To do to Done Dec 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
2 participants
You can’t perform that action at this time.