Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unstage transaction when transaction with higher nonce with same signer is in received block #721

Closed
limebell opened this issue Dec 12, 2019 · 3 comments
Assignees

Comments

@limebell
Copy link
Contributor

@limebell limebell commented Dec 12, 2019

Now staged transactions are broadcasted periodically, so stale transaction should be unstaged to prevent waste of network resource.

@limebell limebell changed the title Unstage transaction when transaction with higher nonce is in received block Unstage transaction when transaction with higher nonce with same signer is in received block Dec 12, 2019
@minhoryang

This comment has been minimized.

Copy link
Contributor

@minhoryang minhoryang commented Dec 14, 2019

I'll dive in this!

@minhoryang

This comment has been minimized.

Copy link
Contributor

@minhoryang minhoryang commented Dec 14, 2019

Planning to add the check logic at the before when Swarm.ProcessTxIds calling BlockChain.StageTransactions()

@minhoryang

This comment has been minimized.

Copy link
Contributor

@minhoryang minhoryang commented Dec 14, 2019

New Plan:
Add the check logic when BlockChain.Append() called (from Non-miner's Swarm.AppendBlockAsync() and Miner's BlockChain.MineBlock())

minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 14, 2019
…once during Append phase
minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 14, 2019
…once during Append phase
minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 14, 2019
…once during Append phase
minhoryang added a commit to minhoryang/libplanet that referenced this issue Dec 15, 2019
…once during Append phase
@longfin longfin closed this in b6fe7e8 Dec 17, 2019
longfin added a commit that referenced this issue Dec 17, 2019
Fixes #721, Unstage Transaction with same signer's lower nonce.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.