Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlockChain<T>.Append() does not validate the given block's index #947

Closed
dahlia opened this issue Aug 7, 2020 · 1 comment · Fixed by #1154
Closed

BlockChain<T>.Append() does not validate the given block's index #947

dahlia opened this issue Aug 7, 2020 · 1 comment · Fixed by #1154
Labels
bug Something isn't working stale The issue is stale

Comments

@dahlia
Copy link
Contributor

dahlia commented Aug 7, 2020 •
edited

Where chain is BlockChain<T> and nextBlock is Block<T>, chain.Append(nextBlock) should accept nextBlock only if nextBlock.Index == chain.Count, but the current implementation does not throw any exception.
@dahlia dahlia added the bug Something isn't working label Aug 7, 2020
@stale
Copy link

stale bot commented Oct 6, 2020

This issue has been automatically marked as stale because it has not had recent activity. Thank you for your contributions.

@stale stale bot added the stale The issue is stale label Oct 6, 2020
dahlia added a commit to dahlia/libplanet that referenced this issue Jan 13, 2021
@dahlia
Test a block with index after nonexistent
0c96b24 
planetarium#947

[changelog skip]
@dahlia dahlia mentioned this issue Jan 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working stale The issue is stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test a block with index after nonexistent dahlia/libplanet
1 participant
@dahlia