Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Address and TxId serializable #124

Merged
merged 2 commits into from Mar 9, 2019

Conversation

Projects
None yet
3 participants
@qria
Copy link
Contributor

commented Mar 9, 2019

Closes #99

@qria qria force-pushed the qria:issue-99 branch from 99ccfbd to dba1dec Mar 9, 2019

@qria qria changed the title Make Address serializable Make Address and TxId serializable Mar 9, 2019

CHANGES.md Outdated
@@ -6,6 +6,8 @@ Version 0.2.0

To be released.

- `Address` and `TxId` is now serializable.

This comment has been minimized.

Copy link
@dahlia

dahlia Mar 9, 2019

Member

is → are

@qria qria force-pushed the qria:issue-99 branch from dba1dec to 3893403 Mar 9, 2019

@longfin
Copy link
Member

left a comment

LGTM, Thanks. @qria

@dahlia

This comment has been minimized.

Copy link
Member

commented Mar 9, 2019

@qria Could you rebase this on the current master?

@qria qria force-pushed the qria:issue-99 branch from 3893403 to c1f17fd Mar 9, 2019

@qria

This comment has been minimized.

Copy link
Contributor Author

commented Mar 9, 2019

@dahlia Done

@codecov

This comment has been minimized.

Copy link

commented Mar 9, 2019

Codecov Report

Merging #124 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #124      +/-   ##
==========================================
+ Coverage   88.07%   88.12%   +0.04%     
==========================================
  Files          61       61              
  Lines        3003     3015      +12     
==========================================
+ Hits         2645     2657      +12     
  Misses        358      358
Impacted Files Coverage Δ
Libplanet/Address.cs 93.58% <100%> (+0.53%) ⬆️
Libplanet/Tx/TxId.cs 88.88% <100%> (+3.17%) ⬆️
@dahlia

dahlia approved these changes Mar 9, 2019

@dahlia dahlia merged commit b662da4 into planetarium:master Mar 9, 2019

4 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/patch 100% of diff hit (target 88.07%)
Details
codecov/project 88.12% (+0.04%) compared to 6f7ef1b
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.