Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peer.EndPoints to Peer.EndPoint #127

Merged
merged 1 commit into from Mar 12, 2019

Conversation

Projects
None yet
2 participants
@longfin
Copy link
Member

commented Mar 11, 2019

This PR replaces Peer.EndPoints with Peer.EndPoint. (as suggested in #126)

@longfin longfin added this to the 0.2.0 milestone Mar 11, 2019

@longfin longfin self-assigned this Mar 11, 2019

@longfin longfin requested review from dahlia and ipdae Mar 11, 2019

@longfin longfin force-pushed the longfin:feature/unify-peer-endpoint branch from b1cb9b5 to b3cdd49 Mar 11, 2019

@longfin

This comment has been minimized.

Copy link
Member Author

commented Mar 11, 2019

Some tests seem to fail. I'll fix it.

CHANGES.md Outdated
@@ -6,7 +6,7 @@ Version 0.2.0

To be released.

- The type of `Peer.Urls` property is changed from `Uri` to `IPEndPoint`.
- `Peer.Urls` is changed to `Peer.EndPoint` represented as single `IPEndPoint`.

This comment has been minimized.

Copy link
@dahlia

dahlia Mar 11, 2019

Member

There were a renaming and a retyping, so we'd better to sum up the explanation at higher view, with links to the issue #120 and #126.

  • Since we decided to depend on TURN (RFC 5766) and STUN (RFC 5389) to work around NAT so that Peer's endpoints don't have to be multiple, Peer.Urls was renamed to Peer.EndPoint and its type also was changed from IImmutableList<Uri> to IPEndPoint. [#120, #126]
@codecov

This comment has been minimized.

Copy link

commented Mar 11, 2019

Codecov Report

Merging #127 into master will increase coverage by 0.05%.
The diff coverage is 73.91%.

@@            Coverage Diff             @@
##           master     #127      +/-   ##
==========================================
+ Coverage   88.12%   88.18%   +0.05%     
==========================================
  Files          61       61              
  Lines        3015     2987      -28     
==========================================
- Hits         2657     2634      -23     
+ Misses        358      353       -5
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 90.72% <66.66%> (+0.76%) ⬆️
Libplanet/Net/Peer.cs 84.61% <87.5%> (-10.39%) ⬇️

@longfin longfin force-pushed the longfin:feature/unify-peer-endpoint branch from b3cdd49 to 92da26d Mar 11, 2019

@dahlia

dahlia approved these changes Mar 11, 2019

@longfin longfin merged commit e7e56e4 into planetarium:master Mar 12, 2019

3 of 4 checks passed

codecov/patch 73.91% of diff hit (target 88.12%)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
codecov/project 88.18% (+0.05%) compared to b662da4
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.