Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IActionContext.Rehearsal property #135

Merged
merged 1 commit into from Mar 20, 2019

Conversation

Projects
None yet
2 participants
@dahlia
Copy link
Member

commented Mar 20, 2019

This implements #131.

@dahlia dahlia added this to the 0.2.0 milestone Mar 20, 2019

@dahlia dahlia self-assigned this Mar 20, 2019

@dahlia dahlia requested review from longfin and earlbread Mar 20, 2019

@longfin
Copy link
Member

left a comment

When naming this type of action, I heard a lot more of dry-run. Is there a particular reason for choosing Rehearsal?

@dahlia

This comment has been minimized.

Copy link
Member Author

commented Mar 20, 2019

When naming this type of action, I heard a log more of dry-run. Is there a particular reason for choosing Rehearsal?

No particular reason. Just the word “rehearsal” came into my mind first. The word “dry-run” is also difficult to conjugate to me because it is basically a two-word verb and we need to insert a hyphen in the middle in order to make it noun.

@codecov

This comment has been minimized.

Copy link

commented Mar 20, 2019

Codecov Report

Merging #135 into master will decrease coverage by 2.79%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master     #135     +/-   ##
=========================================
- Coverage   87.86%   85.06%   -2.8%     
=========================================
  Files          67       67             
  Lines        3213     3215      +2     
=========================================
- Hits         2823     2735     -88     
- Misses        390      480     +90
Impacted Files Coverage Δ
Libplanet/Tx/Transaction.cs 95.97% <100%> (ø) ⬆️
Libplanet/Action/ActionContext.cs 100% <100%> (ø) ⬆️
Libplanet/Net/IceServer.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/IceServerException.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (-80.77%) ⬇️
Libplanet/Net/Swarm.cs 85.07% <0%> (-4.51%) ⬇️

@dahlia dahlia merged commit 63368d1 into planetarium:master Mar 20, 2019

5 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 87.86%)
Details
codecov/project Absolute coverage decreased by -2.79% but relative coverage increased by +12.13% compared to a6f84b7
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.