Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UnexpectedlyTerminatedTxRehearsalException #136

Merged
merged 2 commits into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@dahlia
Copy link
Member

commented Mar 20, 2019

This implements #132.

Upgrade DocFX to v2.40.12
[changelog skip]

@dahlia dahlia added this to the 0.2.0 milestone Mar 20, 2019

@dahlia dahlia self-assigned this Mar 20, 2019

@dahlia dahlia requested review from longfin and earlbread Mar 20, 2019

/// <para>The actual exception that the <see cref="Action"/> threw
/// is stored in the <see cref="Exception.InnerException"/> property.</para>
/// </summary>
public class UnexpectedlyTerminatedTxRehearsalException : Exception

This comment has been minimized.

Copy link
@longfin

longfin Mar 21, 2019

Member
  • Could we seal this class?
  • It would be better if [Serializable] was attached to make it serializable.

This comment has been minimized.

Copy link
@dahlia

dahlia Mar 21, 2019

Author Member

Both ideas are good. I'll do that!

This comment has been minimized.

Copy link
@dahlia

dahlia Mar 21, 2019

Author Member

@longfin I've just amended the last commit.

@dahlia dahlia force-pushed the dahlia:tx-rehearsal-exception branch from 76376c5 to f015490 Mar 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #136 into master will decrease coverage by 3.07%.
The diff coverage is 80%.

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   87.86%   84.79%   -3.08%     
==========================================
  Files          67       68       +1     
  Lines        3215     3229      +14     
==========================================
- Hits         2825     2738      -87     
- Misses        390      491     +101
Impacted Files Coverage Δ
Libplanet/Tx/InvalidTxUpdatedAddressesException.cs 75% <ø> (ø) ⬆️
Libplanet/Tx/InvalidTxException.cs 80% <ø> (ø) ⬆️
...t/Tx/UnexpectedlyTerminatedTxRehearsalException.cs 80% <80%> (ø)
Libplanet/Tx/Transaction.cs 94.93% <80%> (-1.04%) ⬇️
Libplanet/Net/IceServer.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/IceServerException.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (-80.77%) ⬇️
Libplanet/Net/Swarm.cs 84.04% <0%> (-5.54%) ⬇️

@dahlia dahlia merged commit 7f4dea1 into planetarium:master Mar 21, 2019

3 of 5 checks passed

codecov/patch 80% of diff hit (target 87.86%)
Details
codecov/project 84.79% (-3.08%) compared to 63368d1
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.