Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when ciphertext is invalid #140

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Mar 21, 2019

  • Made threw an InvalidCiphertextException when ciphertext is invalid.

@earlbread earlbread self-assigned this Mar 21, 2019

@earlbread earlbread requested review from dahlia and longfin Mar 21, 2019

@earlbread earlbread force-pushed the earlbread:decrypt-throw-exception branch from a289ae1 to 10d62a7 Mar 21, 2019

@dahlia

dahlia approved these changes Mar 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 21, 2019

Codecov Report

Merging #140 into master will decrease coverage by 3.1%.
The diff coverage is 30.76%.

@@            Coverage Diff             @@
##           master     #140      +/-   ##
==========================================
- Coverage   87.36%   84.26%   -3.11%     
==========================================
  Files          68       69       +1     
  Lines        3229     3241      +12     
==========================================
- Hits         2821     2731      -90     
- Misses        408      510     +102
Impacted Files Coverage Δ
Libplanet/Crypto/PrivateKey.cs 89.58% <ø> (ø) ⬆️
Libplanet/Crypto/SymmetricKey.cs 92.3% <100%> (+5.76%) ⬆️
Libplanet/Crypto/InvalidCiphertextException.cs 25% <25%> (ø)
Libplanet/Net/IceServer.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/IceServerException.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (-80.77%) ⬇️
Libplanet/Net/Swarm.cs 82.36% <0%> (-5.28%) ⬇️

@dahlia dahlia merged commit e7b5aec into planetarium:master Mar 21, 2019

3 of 5 checks passed

codecov/patch 30.76% of diff hit (target 87.36%)
Details
codecov/project 84.26% (-3.11%) compared to d50a902
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details

@earlbread earlbread deleted the earlbread:decrypt-throw-exception branch Mar 21, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.