Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw exception when action type is not annotated #144

Merged

Conversation

Projects
3 participants
@earlbread
Copy link
Member

commented Mar 22, 2019

  • Made threw an InvalidActionTypeException if an action type is not annotated with actionTypeAttribute. #28

@earlbread earlbread self-assigned this Mar 22, 2019

@earlbread earlbread requested review from dahlia and longfin Mar 22, 2019

@codecov

This comment has been minimized.

Copy link

commented Mar 22, 2019

Codecov Report

Merging #144 into master will decrease coverage by 2.83%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##           master     #144      +/-   ##
==========================================
- Coverage   87.72%   84.89%   -2.84%     
==========================================
  Files          69       70       +1     
  Lines        3250     3263      +13     
==========================================
- Hits         2851     2770      -81     
- Misses        399      493      +94
Impacted Files Coverage Δ
Libplanet/Action/ActionTypeAttribute.cs 100% <100%> (ø) ⬆️
Libplanet/Tx/InvalidActionTypeException.cs 33.33% <33.33%> (ø)
Libplanet/Net/IceServer.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/IceServerException.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (-80.77%) ⬇️
Libplanet/Net/Swarm.cs 85.32% <0%> (-4.25%) ⬇️
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved Libplanet.Tests/Blockchain/BlockChainTest.cs Outdated
Show resolved Hide resolved Libplanet.Tests/Blockchain/BlockChainTest.cs Outdated
Show resolved Hide resolved Libplanet.Tests/Blockchain/BlockChainTest.cs Outdated
Show resolved Hide resolved Libplanet/Tx/Transaction.cs Outdated

@earlbread earlbread force-pushed the earlbread:invalid-action-type-exception branch 2 times, most recently from 6699605 to 9ecf915 Mar 22, 2019

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Mar 22, 2019

I fixed the code. Please take a look. @dahlia @longfin

@earlbread earlbread force-pushed the earlbread:invalid-action-type-exception branch from 9ecf915 to 0b34c49 Mar 23, 2019

@earlbread earlbread merged commit 90d7413 into planetarium:master Mar 23, 2019

3 of 5 checks passed

codecov/patch 57.14% of diff hit (target 87.72%)
Details
codecov/project 84.89% (-2.84%) compared to 0cf9e8c
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details

@earlbread earlbread deleted the earlbread:invalid-action-type-exception branch Mar 23, 2019

@longfin longfin added this to In progress in comuka-20190320 via automation Mar 23, 2019

@longfin longfin moved this from In progress to Done in comuka-20190320 Mar 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.