Introduce: ConsensusReactor and ConsensusBroadcaster for PBFT
#1528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## pbft #1528 +/- ##
==========================================
- Coverage 26.91% 26.62% -0.30%
==========================================
Files 276 283 +7
Lines 18096 18298 +202
==========================================
Hits 4871 4871
- Misses 12838 13040 +202
Partials 387 387
|
auto-assign
bot
requested review from
dahlia,
greymistcube,
kfangw,
limebell and
longfin
riemannulus
changed the title
ConsensusReactor and ConsensusBroadcaster for PBFT
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
|
We don't implement PBFT now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the consensus reactor architecture for achieving consensus, which is the basis of the PBFT implementation.
@dahlia I've to make the architecture you've mentioned but I re-design my own way. Please review carefully between
ConsensusReactorandConsensusBroadcaster@kfangw Try to implement exactly what you're working stuff. Please review
ConsensusReactor's logic and test code. If don't mind. could you propose more test code like I working on this PR?