Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 0.18.4 into 0.19-maintenance (to be 0.19.2) #1572

Merged
merged 5 commits into from Nov 3, 2021

Conversation

dahlia
Copy link
Contributor

@dahlia dahlia commented Nov 2, 2021

See also #1571.

@dahlia dahlia added the bug Something isn't working label Nov 2, 2021
@dahlia dahlia self-assigned this Nov 2, 2021
@dahlia dahlia added this to In progress in Libplanet via automation Nov 2, 2021
@codecov
Copy link

codecov bot commented Nov 2, 2021

Codecov Report

Merging #1572 (f28a5ea) into 0.19-maintenance (9398c35) will decrease coverage by 51.11%.
The diff coverage is 29.62%.

@@                  Coverage Diff                  @@
##           0.19-maintenance    #1572       +/-   ##
=====================================================
- Coverage             77.88%   26.76%   -51.12%     
=====================================================
  Files                   279      279               
  Lines                 18235    18256       +21     
=====================================================
- Hits                  14202     4887     -9315     
- Misses                 3439    12986     +9547     
+ Partials                594      383      -211     
Impacted Files Coverage Δ
Libplanet/KeyStore/ProtectedPrivateKey.cs 0.00% <0.00%> (-98.19%) ⬇️
Libplanet/Crypto/PrivateKey.cs 46.09% <34.78%> (-39.37%) ⬇️
Libplanet/Net/IceServer.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/PeerState.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/FixedSizedQueue.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/BlockDemand.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/Messages/Tx.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/SwarmOptions.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/Messages/Ping.cs 0.00% <0.00%> (-100.00%) ⬇️
Libplanet/Net/Messages/Pong.cs 0.00% <0.00%> (-100.00%) ⬇️
... and 177 more

Libplanet automation moved this from In progress to Reviewer approved Nov 3, 2021
@dahlia dahlia merged commit f89db86 into planetarium:0.19-maintenance Nov 3, 2021
Libplanet automation moved this from Reviewer approved to Done Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants