Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the issue that the document's "View Source" link was broken #171

Merged
merged 1 commit into from Apr 3, 2019

Conversation

jckdotim
Copy link
Contributor

@jckdotim jckdotim commented Apr 2, 2019

This patch fixes #82. While building the code, Uno.CodeGen generates [separated files]1 so that DocFX catches another automatically generated code. That's why View Source link was broken. I changed the Docs's build order to solve this issue.

Footnotes

  1. https://github.com/nventive/Uno.CodeGen/blob/master/doc/Equality%20Generation.md

@jckdotim jckdotim requested review from dahlia and longfin April 2, 2019 23:57
@codecov
Copy link

codecov bot commented Apr 3, 2019

Codecov Report

Merging #171 into master will decrease coverage by 2.78%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #171      +/-   ##
==========================================
- Coverage   86.95%   84.17%   -2.79%     
==========================================
  Files          69       69              
  Lines        3165     3165              
==========================================
- Hits         2752     2664      -88     
- Misses        413      501      +88
Impacted Files Coverage Δ
Libplanet/Net/IceServer.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/IceServerException.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (-80.77%) ⬇️
Libplanet/Net/Swarm.cs 83.75% <0%> (-4.16%) ⬇️

Copy link
Member

@longfin longfin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for patch.

@jckdotim jckdotim merged commit 049a2f8 into planetarium:master Apr 3, 2019
dahlia pushed a commit to dahlia/libplanet that referenced this pull request Apr 15, 2021
limebell pushed a commit to limebell/libplanet that referenced this pull request Jul 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Links to GitHub source code in the docs seem broken
2 participants