Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Swarm.PreloadAsync() #206

Merged
merged 5 commits into from Apr 18, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented Apr 17, 2019

This PR adds Swarm.PreloadAsync() to explicitly downloads the blocks before starting. and, it also adds BlockDownloadState to provide current download state to caller(game).

@longfin longfin force-pushed the longfin:feature/swarm-ibd branch from 398642e to 7924fe8 Apr 17, 2019

@longfin longfin requested review from dahlia and earlbread Apr 17, 2019

Show resolved Hide resolved CHANGES.md Outdated
Update CHANGES.md
Co-Authored-By: longfin <longfinfunnel@gmail.com>
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs
Show resolved Hide resolved Libplanet/Net/Swarm.cs
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated
Apply suggestions from code review
Co-Authored-By: longfin <longfinfunnel@gmail.com>
@codecov

This comment has been minimized.

Copy link

commented Apr 17, 2019

Codecov Report

Merging #206 into master will decrease coverage by 3.2%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   87.44%   84.24%   -3.21%     
==========================================
  Files          72       73       +1     
  Lines        3370     3376       +6     
==========================================
- Hits         2947     2844     -103     
- Misses        423      532     +109
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 81.79% <100%> (-6.03%) ⬇️
Libplanet/Net/BlockDownloadState.cs 100% <100%> (ø)
Libplanet/Net/IceServer.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/IceServerException.cs 0% <0%> (-100%) ⬇️
Libplanet/Net/NetworkStreamProxy.cs 0% <0%> (-77.78%) ⬇️

@longfin longfin requested review from earlbread and dahlia Apr 17, 2019

Show resolved Hide resolved CHANGES.md Outdated
Update CHANGES.md
Co-Authored-By: longfin <longfinfunnel@gmail.com>

@longfin longfin requested a review from earlbread Apr 17, 2019

Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Apply suggestions from code review
Co-Authored-By: longfin <longfinfunnel@gmail.com>

@longfin longfin dismissed stale reviews from earlbread and earlbread via a3fded4 Apr 17, 2019

@longfin longfin requested review from dahlia and earlbread and removed request for dahlia Apr 17, 2019

@dahlia

dahlia approved these changes Apr 17, 2019

@longfin longfin merged commit 8b4f1fe into planetarium:master Apr 18, 2019

5 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 87.44%)
Details
codecov/project Absolute coverage decreased by -3.2% but relative coverage increased by +12.55% compared to b84b302
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.