Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove validation when getting block #231

Merged
merged 1 commit into from May 7, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented May 7, 2019

  • Removed block.Validate() when getting a block using Blocks[index].

@earlbread earlbread requested review from dahlia and longfin May 7, 2019

@earlbread earlbread self-assigned this May 7, 2019

CHANGES.md Outdated
@@ -70,6 +70,7 @@ To be released.
- The difficulty was changed from representing the number of leading zeros of
target number to representing a divisor to obtain the target number.
[[#213]]
- `BlockSet<T>[int]` changed so as not to validate a block.

This comment has been minimized.

Copy link
@longfin

longfin May 7, 2019

Member

I also think that previous behavior (validate when getting) wasn't expectable, so we can skip this phrase. (or organize at later.)

This comment has been minimized.

Copy link
@dahlia

dahlia May 7, 2019

Member

IMO it should go to behavioral changes.

This comment has been minimized.

Copy link
@earlbread

earlbread May 7, 2019

Author Member

It is already in behavioral changes. Did you mean bug fixes?

@earlbread earlbread force-pushed the earlbread:block-get-remove-validate branch from 5ce4fab to ecba409 May 7, 2019

@dahlia

dahlia approved these changes May 7, 2019

@earlbread earlbread merged commit 0384134 into planetarium:master May 7, 2019

3 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details

@earlbread earlbread deleted the earlbread:block-get-remove-validate branch May 7, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.