Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix relaying bug with NAT #240

Merged
merged 2 commits into from May 15, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented May 15, 2019

This PR fixes a bug that Swarm could not properly communicate with Peer behind NAT. to accomplish that, it made changes as belows.

  • Added Peer.PublicIPAddress which indicates the IP address to be used when the peer connects to another peer.
    • it's internal and does not affect public interface.
  • Made Swarm.CreatePermission() uses Peer.PublicIPAddress instead of Peer.Endpoint if available.

longfin added some commits May 15, 2019

@longfin longfin changed the title Fix NAT relay bug Fix relaying bug with NAT May 15, 2019

@longfin longfin force-pushed the longfin:bugfix/nat-to-nat branch from ed2a32e to f4a7b25 May 15, 2019

@longfin longfin requested review from dahlia and earlbread May 15, 2019

@longfin longfin marked this pull request as ready for review May 15, 2019

@dahlia

dahlia approved these changes May 15, 2019

@longfin longfin merged commit 8b7598f into planetarium:master May 15, 2019

8 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
planetarium.libplanet Build #20190515.8 succeeded
Details
planetarium.libplanet (Linux) Linux succeeded
Details
planetarium.libplanet (Windows) Windows succeeded
Details
planetarium.libplanet (Windows_coverage) Windows_coverage succeeded
Details
planetarium.libplanet (macOS) macOS succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.