Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove state comparison in EvaluateActionsGradually #241

Merged
merged 1 commit into from May 16, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented May 15, 2019

This PR removes state comparison in AccountStateDeltaImpl.SetState() (used by IAction.Execute()) to improve performance of action evaluation.

@longfin longfin force-pushed the longfin:feature/remove-epoch-check branch from a693780 to 6db9bc2 May 15, 2019

@longfin longfin marked this pull request as ready for review May 15, 2019

@longfin longfin requested review from dahlia and earlbread May 16, 2019

Show resolved Hide resolved CHANGES.md Outdated

@longfin longfin force-pushed the longfin:feature/remove-epoch-check branch from 6db9bc2 to de99218 May 16, 2019

@longfin longfin requested review from earlbread and dahlia and removed request for earlbread May 16, 2019

@dahlia

dahlia approved these changes May 16, 2019

@longfin longfin merged commit 5d7d44c into planetarium:master May 16, 2019

8 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
planetarium.libplanet Build #20190516.3 succeeded
Details
planetarium.libplanet (Linux) Linux succeeded
Details
planetarium.libplanet (Windows) Windows succeeded
Details
planetarium.libplanet (Windows_coverage) Windows_coverage succeeded
Details
planetarium.libplanet (macOS) macOS succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.