Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Force dotnet if running on mono #247

Merged
merged 6 commits into from May 22, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented May 20, 2019

  • This PR mainly aids hanging unit tests running on Mono in Windows by calling AsyncIO.ForceDotNet.Force() to enforce using sockets in .NET, not Windows native.
  • It's also prevents some other possible hanging unit tests by eliminating Swarm.Add() usages.
  • It's also fixes ArgumentOutOfRangeException that occurred when requesting a hash when BlockChain <T> was empty.

@longfin longfin force-pushed the longfin:bugfix/asyncio-force-dotnet branch 2 times, most recently from d8dc061 to 10476bb May 20, 2019

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #247 into master will decrease coverage by 0.18%.
The diff coverage is 82.35%.

@@            Coverage Diff             @@
##           master     #247      +/-   ##
==========================================
- Coverage   87.27%   87.08%   -0.19%     
==========================================
  Files         180      180              
  Lines       11394    11386       -8     
==========================================
- Hits         9944     9916      -28     
- Misses       1207     1227      +20     
  Partials      243      243
Impacted Files Coverage Δ
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.91% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 96.28% <100%> (+0.02%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.56% <66.66%> (-0.83%) ⬇️
Libplanet/Net/Swarm.cs 75.84% <84.21%> (-1.07%) ⬇️

@longfin longfin force-pushed the longfin:bugfix/asyncio-force-dotnet branch 7 times, most recently from 5d37578 to 09c0abc May 20, 2019

@longfin longfin requested review from dahlia and earlbread May 21, 2019

@longfin longfin marked this pull request as ready for review May 21, 2019

new HashSet<Peer> { null, b.AsPeer, c.AsPeer },
peers.ToHashSet());
}

This comment has been minimized.

Copy link
@earlbread

earlbread May 21, 2019

Member

Swarm is not going to be used as an ICollection anymore?

This comment has been minimized.

Copy link
@longfin

longfin May 21, 2019

Author Member

I will try to do so. would it be better to handle this issue?

This comment has been minimized.

Copy link
@earlbread

earlbread May 21, 2019

Member

No, I think it would be better to handle this in another PR.

@longfin longfin force-pushed the longfin:bugfix/asyncio-force-dotnet branch from 09c0abc to 3b44a66 May 21, 2019

@longfin longfin force-pushed the longfin:bugfix/asyncio-force-dotnet branch from 3b44a66 to e5938ce May 22, 2019

@longfin

This comment has been minimized.

Copy link
Member Author

commented May 22, 2019

It still appears intermittently failing, but seems to be more stabilized than before. PTAL @earlbread @dahlia

@longfin longfin requested a review from earlbread May 22, 2019

@dahlia

dahlia approved these changes May 22, 2019

@longfin longfin merged commit 24657dd into planetarium:master May 22, 2019

14 of 15 checks passed

codecov/patch 82.35% of diff hit (target 87.27%)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.08% (-0.19%) compared to 0db8c7a
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190522.20 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.