Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update access modifier of exception to public, resolve #133 #251

Merged
merged 2 commits into from May 21, 2019

Conversation

Projects
None yet
4 participants
@moreal
Copy link
Contributor

commented May 20, 2019

Update access modifier of InvalidBlockTimestampException to public, to resolve #133

@dahlia
Copy link
Member

left a comment

  • Could you rebase the commit b12d75a on the current master (instead of merging back the master to this branch)?
  • As this is an interfacial change, please write a changelog about this; see also CHANGES.md file.

@moreal moreal force-pushed the moreal:make-execeptions-public-133 branch from 9fe2e86 to b12d75a May 20, 2019

@codecov

This comment has been minimized.

Copy link

commented May 20, 2019

Codecov Report

Merging #251 into master will decrease coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #251      +/-   ##
==========================================
- Coverage   87.03%   86.94%   -0.09%     
==========================================
  Files         179      179              
  Lines       11126    11126              
==========================================
- Hits         9683     9673      -10     
- Misses       1202     1211       +9     
- Partials      241      242       +1
Impacted Files Coverage Δ
Libplanet/Blocks/InvalidBlockTimestampException.cs 100% <ø> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 91.94% <0%> (-1.43%) ⬇️
Libplanet/Crypto/PrivateKey.cs 84.68% <0%> (-0.91%) ⬇️
@dahlia
Copy link
Member

left a comment

Could you rebase this on the current master?

Show resolved Hide resolved CHANGES.md Outdated
Update access modifier of exception to public
Update access modifier of InvalideBlockTimestampException to public

@moreal moreal force-pushed the moreal:make-execeptions-public-133 branch from aa5cffc to 0ad364b May 20, 2019

Show resolved Hide resolved CHANGES.md Outdated

@moreal moreal force-pushed the moreal:make-execeptions-public-133 branch from bb183e1 to 1ed2b77 May 20, 2019

@dahlia

dahlia approved these changes May 20, 2019

@dahlia

This comment has been minimized.

Copy link
Member

commented May 20, 2019

Congrats and thanks for your first contribution!

@earlbread
Copy link
Member

left a comment

Thank you for your first contribution!

@longfin longfin merged commit 7da1cdd into planetarium:master May 21, 2019

15 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch Coverage not affected when comparing eb4554a...1ed2b77
Details
codecov/project 86.94% (-0.09%) compared to eb4554a
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190520.43 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.