Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix concurrency error in TurnClient.AcceptRelayedStreamAsync() #256

Merged
merged 2 commits into from May 23, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented May 23, 2019

#248 occurs when two or more nodes simultaneously request a TURN relay for one node. this patch fixes it.

Also in this process, I let Libplanet.Stun use Serilog, and upgrade the version used by Libplanet.

@longfin longfin force-pushed the longfin:bugfix/concurrent-turn-relay branch from c48e95a to 6afd9bc May 23, 2019

@longfin longfin requested review from dahlia and earlbread May 23, 2019

@longfin longfin marked this pull request as ready for review May 23, 2019

@dahlia

dahlia approved these changes May 23, 2019

@codecov

This comment has been minimized.

Copy link

commented May 23, 2019

Codecov Report

Merging #256 into master will decrease coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #256      +/-   ##
==========================================
- Coverage   86.99%   86.96%   -0.03%     
==========================================
  Files         180      180              
  Lines       11386    11389       +3     
==========================================
  Hits         9905     9905              
- Misses       1238     1241       +3     
  Partials      243      243
Impacted Files Coverage Δ
Libplanet.Stun/Stun/TurnClient.cs 0% <0%> (ø) ⬆️

@longfin longfin merged commit fd17cd9 into planetarium:master May 23, 2019

14 of 15 checks passed

codecov/patch 0% of diff hit (target 86.99%)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 86.96% (-0.03%) compared to 24657dd
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190523.2 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.