Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add IPv6 support to Libplanet.Stun #271

Merged
merged 3 commits into from Jun 14, 2019

Conversation

Projects
None yet
4 participants
@moreal
Copy link
Contributor

commented Jun 3, 2019

It resolves #267

This PR adds the following items.

  • Add testcase for support IPv6 and implement
  • Use Theory, MemberData to reduce code duplication in testcode
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md

@moreal moreal force-pushed the moreal:support-ipv6-for-turnclient-267 branch from acc7cd7 to 33e4e90 Jun 3, 2019

@moreal moreal force-pushed the moreal:support-ipv6-for-turnclient-267 branch from 33e4e90 to 587a0ef Jun 3, 2019

@earlbread
Copy link
Member

left a comment

This currently hangs on the macOS_Unity test even though I ran it again a few times.
I think we should take a look.

@moreal moreal dismissed stale reviews from dahlia and longfin via 52dcba8 Jun 4, 2019

@moreal moreal force-pushed the moreal:support-ipv6-for-turnclient-267 branch 2 times, most recently from 52dcba8 to c118645 Jun 4, 2019

@earlbread

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

When I change the Theory to Fact, the test runs fine. Maybe it's a Unity bug related to xUnit.

@dahlia

This comment has been minimized.

Copy link
Member

commented Jun 4, 2019

When I change the Theory to Fact, the test runs fine. Maybe it's a Unity bug related to xUnit.

I believe it's a bug of xunit-unity-runner. Although I should investigate this, I can't guarantee when it will end, so I suggest @moreal to try to work around this bug at this moment in time. 🙇🏻‍♂️

@dahlia dahlia added the autorebase label Jun 13, 2019

@moreal moreal force-pushed the moreal:support-ipv6-for-turnclient-267 branch from c118645 to 5bd1d87 Jun 13, 2019

@autorebase autorebase bot removed the autorebase label Jun 14, 2019

@autorebase

This comment has been minimized.

Copy link
Contributor

commented Jun 14, 2019

The rebase failed:

Not Found

To rebase manually, run these commands in your terminal:

# Fetch latest updates from GitHub.
git fetch
# Create new working tree.
git worktree add .worktrees/rebase support-ipv6-for-turnclient-267
# Navigate to the new directory.
cd .worktrees/rebase
# Rebase and resolve the likely conflicts.
git rebase --interactive --autosquash master
# Push the new branch state to GitHub.
git push --force
# Go back to the original working tree.
cd ../..
# Delete the working tree.
git worktree remove .worktrees/rebase
@codecov

This comment has been minimized.

Copy link

commented Jun 14, 2019

Codecov Report

Merging #271 into master will increase coverage by 0.01%.
The diff coverage is 89.7%.

@@            Coverage Diff             @@
##           master     #271      +/-   ##
==========================================
+ Coverage    87.3%   87.31%   +0.01%     
==========================================
  Files         185      185              
  Lines       12083    12128      +45     
==========================================
+ Hits        10549    10590      +41     
- Misses       1296     1299       +3     
- Partials      238      239       +1
Impacted Files Coverage Δ
....Tests/Stun/Attributes/StunAddressExtensionTest.cs 100% <100%> (ø) ⬆️
...lanet.Stun/Stun/Attributes/StunAddressExtension.cs 78.26% <87.27%> (+13.04%) ⬆️
@dahlia

This comment has been minimized.

Copy link
Member

commented Jun 14, 2019

@moreal Could you rebase it on the current master to avoid cross-merging between upstream and downstream?

moreal added some commits Jun 2, 2019

Add testcase for ipv6 and refactor
Add testcase for ipv6 to StunAddressExtensionTest
Also used Theory, MemberData Attribute to reduce code duplication

It will need feedback
Support IPv6 in StunAddress
Support IPv6 in StunAddress
It needs feedback for refactoring and implement
Update CHANGES
Co-Authored-By: Dogeon Lee <dev.moreal@gmail.com>

@moreal moreal force-pushed the moreal:support-ipv6-for-turnclient-267 branch from 272e00e to 48f0438 Jun 14, 2019

@dahlia

dahlia approved these changes Jun 14, 2019

@dahlia dahlia merged commit 2ef7d6f into planetarium:master Jun 14, 2019

16 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 89.7% of diff hit (target 87.3%)
Details
codecov/project 87.31% (+0.01%) compared to 25a3aa8
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190614.6 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.