Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Swarm.StopAsync() #275

Merged
merged 8 commits into from Jun 10, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented Jun 5, 2019

This PR fixes issues as below.

  • Fixed a bug that Swarm.StopAsync() didn't stop properly during Swarm.Preload()
  • Filled up cancellation support with CancellationToken on TAP methods.
@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #275 into master will decrease coverage by 0.13%.
The diff coverage is 92.4%.

@@            Coverage Diff            @@
##           master    #275      +/-   ##
=========================================
- Coverage   87.04%   86.9%   -0.14%     
=========================================
  Files         180     180              
  Lines       11532   11555      +23     
=========================================
+ Hits        10038   10042       +4     
- Misses       1250    1270      +20     
+ Partials      244     243       -1
Impacted Files Coverage Δ
Libplanet.Tests/Net/SwarmTest.cs 93.06% <100%> (-0.03%) ⬇️
Libplanet/Net/Swarm.cs 74.14% <91.78%> (-1.08%) ⬇️
Libplanet/Crypto/PrivateKey.cs 85.58% <0%> (+0.9%) ⬆️

@longfin longfin force-pushed the longfin:bugfix/swarm-stop branch 5 times, most recently from 6ad80f7 to 48e3704 Jun 5, 2019

@longfin longfin changed the title Tune Swarm.StopAsync() Fix Swarm.StopAsync() Jun 7, 2019

@longfin longfin force-pushed the longfin:bugfix/swarm-stop branch from 48e3704 to 268147f Jun 7, 2019

@longfin longfin marked this pull request as ready for review Jun 7, 2019

Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated

@longfin longfin requested review from dahlia and earlbread Jun 10, 2019

@longfin longfin dismissed stale reviews from dahlia and earlbread via 1091414 Jun 10, 2019

@longfin longfin force-pushed the longfin:bugfix/swarm-stop branch from 91048ce to 1091414 Jun 10, 2019

@dahlia

dahlia approved these changes Jun 10, 2019

@longfin longfin merged commit 990e22a into planetarium:master Jun 10, 2019

16 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 92.4% of diff hit (target 87.04%)
Details
codecov/project Absolute coverage decreased by -0.13% but relative coverage increased by +5.36% compared to 1fadef8
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190610.7 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.