Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send multiple blocks in one message #276

Merged
merged 2 commits into from Jun 5, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Jun 5, 2019

This makes Swarm send and receive multiple blocks with one message instead of one block per message. #273

@earlbread earlbread self-assigned this Jun 5, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 5, 2019

Codecov Report

Merging #276 into master will increase coverage by 0.02%.
The diff coverage is 92.66%.

@@            Coverage Diff             @@
##           master     #276      +/-   ##
==========================================
+ Coverage   87.03%   87.06%   +0.02%     
==========================================
  Files         180      180              
  Lines       11444    11532      +88     
==========================================
+ Hits         9960    10040      +80     
- Misses       1241     1249       +8     
  Partials      243      243
Impacted Files Coverage Δ
Libplanet/Net/Swarm.cs 75.29% <100%> (+0.33%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 93.08% <100%> (+0.52%) ⬆️
Libplanet/Net/Messages/Message.cs 83.63% <100%> (ø) ⬆️
Libplanet/Net/Messages/GetBlocks.cs 88.23% <69.23%> (-11.77%) ⬇️
Libplanet/Net/Messages/Blocks.cs 84.61% <84.61%> (ø)

@earlbread earlbread force-pushed the earlbread:get-blocks branch 3 times, most recently from b2c6ac0 to 8e672ec Jun 5, 2019

@earlbread earlbread force-pushed the earlbread:get-blocks branch from 8e672ec to 00cac59 Jun 5, 2019

@earlbread earlbread marked this pull request as ready for review Jun 5, 2019

@earlbread earlbread requested review from longfin and dahlia and removed request for longfin Jun 5, 2019

Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved Libplanet/Net/Messages/Blocks.cs
Show resolved Hide resolved Libplanet/Net/Messages/Message.cs Outdated

@earlbread earlbread force-pushed the earlbread:get-blocks branch 3 times, most recently from 8f3134d to 9012f05 Jun 5, 2019

@earlbread earlbread force-pushed the earlbread:get-blocks branch from 9012f05 to 81068e1 Jun 5, 2019

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Jun 5, 2019

I applied the review suggestions. Please take a look.

@longfin

longfin approved these changes Jun 5, 2019

@dahlia

dahlia approved these changes Jun 5, 2019

@dahlia dahlia added this to the 0.4.0 milestone Jun 5, 2019

@earlbread earlbread merged commit 2cd3480 into planetarium:master Jun 5, 2019

16 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 92.66% of diff hit (target 87.03%)
Details
codecov/project 87.06% (+0.02%) compared to 36f7206
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190605.13 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:get-blocks branch Jun 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.