Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bugs when forking TxNonce #281

Merged
merged 2 commits into from Jun 13, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Jun 12, 2019

  • Fixed a bug where the first TxNonce of an address is not stripped when forking using FileStore.ForkTxNonce() method.
  • Fixed a bug where LiteDBStore.GetTxNonce() method throws a System.IO.IOException when reading a zero-length file.

@earlbread earlbread requested review from dahlia and longfin Jun 12, 2019

@earlbread earlbread self-assigned this Jun 12, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 12, 2019

Codecov Report

Merging #281 into master will increase coverage by 5.16%.
The diff coverage is 92.42%.

@@            Coverage Diff             @@
##           master     #281      +/-   ##
==========================================
+ Coverage   82.23%   87.39%   +5.16%     
==========================================
  Files         161      185      +24     
  Lines       11370    12083     +713     
==========================================
+ Hits         9350    10560    +1210     
+ Misses       1810     1285     -525     
- Partials      210      238      +28
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreTest.cs 98.52% <100%> (+0.12%) ⬆️
Libplanet/Store/FileStore.cs 93.47% <100%> (+0.01%) ⬆️
Libplanet/Store/LiteDBStore.cs 93.48% <73.68%> (-0.99%) ⬇️
....Stun.Tests/Stun/Messages/ConnectionAttemptTest.cs 100% <0%> (ø)
...Stun/Messages/ConnectionBindSuccessResponseTest.cs 100% <0%> (ø)
...Tests/Stun/Messages/AllocateSuccessResponseTest.cs 100% <0%> (ø)
...un.Tests/Stun/Messages/RefreshErrorResponseTest.cs 100% <0%> (ø)
...Stun.Tests/Stun/Attributes/MessageIntegrityTest.cs 100% <0%> (ø)
...et.Stun.Tests/Stun/Messages/AllocateRequestTest.cs 100% <0%> (ø)
...bplanet.Stun.Tests/Stun/Attributes/LifetimeTest.cs 100% <0%> (ø)
... and 47 more

@earlbread earlbread changed the title Fixed bugs when forking TxNonce Fix bugs when forking TxNonce Jun 12, 2019

Show resolved Hide resolved Libplanet/Store/LiteDBStore.cs Outdated
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated

@earlbread earlbread force-pushed the earlbread:fix-fork-tx-nonce branch from e1cc8ea to 4ed6fbc Jun 12, 2019

@dahlia

dahlia approved these changes Jun 13, 2019

@earlbread earlbread merged commit 51b1fff into planetarium:master Jun 13, 2019

16 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 92.42% of diff hit (target 82.23%)
Details
codecov/project 87.39% (+5.16%) compared to 03caf77
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190612.2 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:fix-fork-tx-nonce branch Jun 13, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.