Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added cancellation support to TurnClient #287

Merged
merged 3 commits into from Jun 18, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented Jun 17, 2019

This PR added cancellation support to async methods in TurnClient.

and, it also fixes a bug that TurnClient.Dispose() doesn't stop properly when control socket has disconnected.

@longfin longfin force-pushed the longfin:bugfix/turn-client-cancel branch from dacadfc to 3c91165 Jun 17, 2019

@longfin longfin marked this pull request as ready for review Jun 17, 2019

Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated
@codecov

This comment has been minimized.

Copy link

commented Jun 17, 2019

Codecov Report

Merging #287 into master will increase coverage by <.01%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #287      +/-   ##
==========================================
+ Coverage   87.25%   87.25%   +<.01%     
==========================================
  Files         185      185              
  Lines       12128    12136       +8     
==========================================
+ Hits        10582    10589       +7     
- Misses       1307     1308       +1     
  Partials      239      239
Impacted Files Coverage Δ
Libplanet.Stun/Stun/TurnClient.cs 0% <0%> (ø) ⬆️
Libplanet/Net/Swarm.cs 74.14% <0%> (-0.08%) ⬇️
Libplanet.Tests/Net/SwarmTest.cs 93.06% <0%> (+1.23%) ⬆️

longfin and others added some commits Jun 17, 2019

@longfin longfin force-pushed the longfin:bugfix/turn-client-cancel branch from a67e03f to a6c99e4 Jun 18, 2019

@longfin longfin requested review from dahlia and earlbread Jun 18, 2019

@longfin longfin merged commit 41c94f5 into planetarium:master Jun 18, 2019

15 of 16 checks passed

codecov/patch 0% of diff hit (target 87.25%)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.25% (+<.01%) compared to f3421d9
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190618.7 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.