Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine creating and staging transaction interface #294

Merged
merged 2 commits into from Jun 20, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Jun 18, 2019

  • Combines creating and staging of transaction interfaces with the BlockChain<T>.MakeTransaction() method.

@earlbread earlbread requested review from dahlia and longfin Jun 18, 2019

@earlbread earlbread self-assigned this Jun 18, 2019

@earlbread earlbread force-pushed the earlbread:fix-transaction-interface branch 2 times, most recently from 7757ab6 to 92b9453 Jun 18, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 18, 2019

Codecov Report

Merging #294 into master will increase coverage by 0.05%.
The diff coverage is 98.6%.

@@            Coverage Diff             @@
##           master     #294      +/-   ##
==========================================
+ Coverage   87.38%   87.44%   +0.05%     
==========================================
  Files         186      186              
  Lines       12449    12502      +53     
==========================================
+ Hits        10879    10932      +53     
+ Misses       1323     1321       -2     
- Partials      247      249       +2
Impacted Files Coverage Δ
Libplanet/Tx/Transaction.cs 94.61% <100%> (ø) ⬆️
Libplanet/Blocks/Block.cs 83.77% <100%> (ø) ⬆️
Libplanet/Blockchain/BlockChain.cs 96.41% <97.5%> (-0.13%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.57% <97.56%> (-0.06%) ⬇️
Libplanet.Tests/Common/Action/DumbAction.cs 78.12% <0%> (+1.56%) ⬆️
Show resolved Hide resolved Libplanet/Blocks/Block.cs Outdated

@earlbread earlbread force-pushed the earlbread:fix-transaction-interface branch from 92b9453 to 4ef0cad Jun 18, 2019

actionsArray,
sig
);
}

This comment has been minimized.

Copy link
@dahlia

dahlia Jun 19, 2019

Member

Does this method have to be removed at all? I thought this is fine to remain, and BlockChain<T>.MakeTransaction() method could be a thin façade on this.

This comment has been minimized.

Copy link
@earlbread

earlbread Jun 19, 2019

Author Member

I think it's okay to leave this, but is there a use case?

Show resolved Hide resolved Libplanet/Blocks/Block.cs

@earlbread earlbread force-pushed the earlbread:fix-transaction-interface branch 2 times, most recently from 5b407b3 to ad0a9b8 Jun 19, 2019

@earlbread earlbread force-pushed the earlbread:fix-transaction-interface branch from ad0a9b8 to 03a4753 Jun 20, 2019

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Jun 20, 2019

I made Transaction<T>.Create(), BlockChain<T>.GetNonce() and BlockChain<T>.StageTransactions() to public again to have options to create Transaction.

@earlbread earlbread requested review from dahlia and longfin Jun 20, 2019

@dahlia

dahlia approved these changes Jun 20, 2019

@earlbread earlbread merged commit 1863473 into planetarium:master Jun 20, 2019

14 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
docs Libplanet docs generated by DocFX
Details
planetarium.libplanet Build #20190620.1 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:fix-transaction-interface branch Jun 20, 2019

@longfin longfin referenced this pull request Jun 24, 2019

Merged

Stabilize mining speed #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.