Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Swarm broadcast transactions periodically #297

Merged
merged 10 commits into from Jun 27, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Jun 21, 2019

This makes Swarm broadcast transactions periodically. To do this, I make staged Transactions store whether to broadcast.

@earlbread earlbread requested review from dahlia and longfin Jun 21, 2019

@earlbread earlbread self-assigned this Jun 21, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 21, 2019

Codecov Report

Merging #297 into master will increase coverage by 0.19%.
The diff coverage is 99.03%.

@@            Coverage Diff            @@
##           master    #297      +/-   ##
=========================================
+ Coverage   87.41%   87.6%   +0.19%     
=========================================
  Files         187     187              
  Lines       12508   12677     +169     
=========================================
+ Hits        10934   11106     +172     
+ Misses       1325    1322       -3     
  Partials      249     249
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 100% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 52.06% <0%> (ø) ⬆️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.58% <100%> (+0.01%) ⬆️
Libplanet/Blockchain/BlockChain.cs 96.55% <100%> (+0.14%) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 93.67% <100%> (+0.61%) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.71% <100%> (+0.05%) ⬆️
Libplanet/Store/FileStore.cs 93.4% <100%> (+0.18%) ⬆️
Libplanet/Store/LiteDBStore.cs 92.39% <100%> (+0.13%) ⬆️
Libplanet/Net/Swarm.cs 75.05% <97.56%> (+0.94%) ⬆️
Show resolved Hide resolved Libplanet/Store/LiteDBStore.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs
Show resolved Hide resolved Libplanet/Store/BaseStore.cs

@earlbread earlbread force-pushed the earlbread:broadcast-tx branch 6 times, most recently from 215e69f to 929fdd9 Jun 24, 2019

@earlbread earlbread force-pushed the earlbread:broadcast-tx branch from 929fdd9 to 43b8541 Jun 26, 2019

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Jun 26, 2019

I applied review suggestions and fixed a problem with test timeout. Please take a look.

Show resolved Hide resolved Libplanet/Store/IStore.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated

@earlbread earlbread force-pushed the earlbread:broadcast-tx branch from 43b8541 to 58e7c9f Jun 26, 2019

Show resolved Hide resolved CHANGES.md

@earlbread earlbread force-pushed the earlbread:broadcast-tx branch from 6b8d2e0 to 4471741 Jun 26, 2019

@dahlia

dahlia approved these changes Jun 26, 2019

@earlbread earlbread merged commit 5bd1197 into planetarium:master Jun 27, 2019

17 checks passed

Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 99.03% of diff hit (target 87.41%)
Details
codecov/project 87.6% (+0.19%) compared to 15a95bb
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190626.7 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:broadcast-tx branch Jun 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.