Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve TurnClient connection #308

Merged
merged 2 commits into from Jun 27, 2019

Conversation

Projects
None yet
3 participants
@longfin
Copy link
Member

commented Jun 27, 2019

This PR adds improves connectivity of TurnClient._control by adding TurnClient.EnsureConnection to ensure _control connection before processing.

@longfin longfin requested review from dahlia and earlbread Jun 27, 2019

@longfin longfin force-pushed the longfin:feature/ensure-turn-connection branch 2 times, most recently from cb5a2a7 to b272c40 Jun 27, 2019

@longfin longfin marked this pull request as ready for review Jun 27, 2019

@earlbread
Copy link
Member

left a comment

It seems to need to rebase.

Show resolved Hide resolved CHANGES.md Outdated
@codecov

This comment has been minimized.

Copy link

commented Jun 27, 2019

Codecov Report

Merging #308 into master will decrease coverage by 0.15%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #308      +/-   ##
==========================================
- Coverage    87.6%   87.45%   -0.16%     
==========================================
  Files         187      187              
  Lines       12677    12690      +13     
==========================================
- Hits        11106    11098       -8     
- Misses       1322     1343      +21     
  Partials      249      249
Impacted Files Coverage Δ
Libplanet/Net/IceServer.cs 0% <0%> (ø) ⬆️
Libplanet.Stun/Stun/TurnClient.cs 0% <0%> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.55% <0%> (-1.13%) ⬇️

@longfin longfin force-pushed the longfin:feature/ensure-turn-connection branch 2 times, most recently from 7f40945 to d777c2c Jun 27, 2019

@longfin longfin force-pushed the longfin:feature/ensure-turn-connection branch from d777c2c to c176346 Jun 27, 2019

@longfin longfin requested review from dahlia and earlbread Jun 27, 2019

@longfin longfin dismissed stale reviews from dahlia and earlbread via 1c914ed Jun 27, 2019

@longfin

This comment has been minimized.

Copy link
Member Author

commented Jun 27, 2019

I've added 1c914ed to avoid ArgumentException on IceServer.CreateTurnClient().

@longfin longfin requested review from dahlia and earlbread Jun 27, 2019

Show resolved Hide resolved Libplanet/Net/IceServer.cs Outdated

@longfin longfin force-pushed the longfin:feature/ensure-turn-connection branch from 1c914ed to f7362fa Jun 27, 2019

@longfin longfin requested a review from dahlia Jun 27, 2019

@dahlia

dahlia approved these changes Jun 27, 2019

@longfin longfin merged commit 07beabf into planetarium:master Jun 27, 2019

16 of 17 checks passed

codecov/patch 0% of diff hit (target 87.6%)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.45% (-0.16%) compared to 5bd1197
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190627.10 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.