Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tx nonces being missed during fork #310

Merged
merged 4 commits into from Jun 29, 2019

Conversation

Projects
None yet
3 participants
@dahlia
Copy link
Member

commented Jun 28, 2019

This fixes the bug #309 that tx nonces being missed during fork, because addresses that aren't stale are missing. To correctly fix this, I've needed IStore.ListTxNonces() as well (note that IStore.ListAddresses() could miss addresses that have never had any states but ever signed some transactions).

@dahlia dahlia added the bug label Jun 28, 2019

@dahlia dahlia added this to the 0.4.0 milestone Jun 28, 2019

@dahlia dahlia requested review from longfin and earlbread Jun 28, 2019

@dahlia dahlia self-assigned this Jun 28, 2019

Show resolved Hide resolved Libplanet/Store/IStore.cs Outdated
Reword docs
Co-Authored-By: Seunghun Lee <waydi1@gmail.com>

@dahlia dahlia requested review from earlbread and longfin Jun 29, 2019

@codecov

This comment has been minimized.

Copy link

commented Jun 29, 2019

Codecov Report

Merging #310 into master will increase coverage by 0.03%.
The diff coverage is 86.31%.

@@            Coverage Diff             @@
##           master     #310      +/-   ##
==========================================
+ Coverage    87.3%   87.33%   +0.03%     
==========================================
  Files         189      189              
  Lines       12604    12690      +86     
==========================================
+ Hits        11004    11083      +79     
- Misses       1344     1356      +12     
+ Partials      256      251       -5
Impacted Files Coverage Δ
Libplanet/Store/BaseStore.cs 100% <ø> (ø) ⬆️
Libplanet.Tests/Store/StoreTracker.cs 52.5% <0%> (-1.82%) ⬇️
Libplanet.Tests/Blockchain/BlockChainTest.cs 98.6% <100%> (ø) ⬆️
Libplanet.Tests/Store/StoreTest.cs 98.65% <100%> (+0.08%) ⬆️
Libplanet/Store/FileStore.cs 90.1% <83.87%> (-0.32%) ⬇️
Libplanet/Blockchain/BlockChain.cs 95.57% <85.71%> (+0.05%) ⬆️
Libplanet/Store/LiteDBStore.cs 92.44% <88.88%> (-0.18%) ⬇️
Libplanet/Net/Swarm.cs 74.75% <0%> (-0.23%) ⬇️
Libplanet.Tests/Store/StoreFixture.cs 100% <0%> (+7.95%) ⬆️

@dahlia dahlia merged commit 472100e into planetarium:master Jun 29, 2019

16 of 17 checks passed

codecov/patch 86.31% of diff hit (target 87.3%)
Details
Travis CI - Pull Request Build Passed
Details
WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/project 87.33% (+0.03%) compared to 5e985f1
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190629.1 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.