Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FileStore.IndexBlockhash return null when index out of range #317

Merged
merged 2 commits into from Jun 29, 2019

Conversation

Projects
None yet
3 participants
@ipdae
Copy link
Member

commented Jun 29, 2019

resolve #214

Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved Libplanet.Tests/Store/StoreTest.cs Outdated
Show resolved Hide resolved Libplanet/Store/FileStore.cs Outdated
@codecov

This comment has been minimized.

Copy link

commented Jun 29, 2019

Codecov Report

Merging #317 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #317      +/-   ##
==========================================
+ Coverage   87.36%   87.37%   +<.01%     
==========================================
  Files         189      189              
  Lines       12690    12699       +9     
==========================================
+ Hits        11087    11096       +9     
  Misses       1352     1352              
  Partials      251      251
Impacted Files Coverage Δ
Libplanet.Tests/Store/StoreTest.cs 98.68% <100%> (+0.02%) ⬆️
Libplanet/Store/FileStore.cs 90.15% <100%> (+0.04%) ⬆️

@ipdae ipdae force-pushed the ipdae:bugfix/issues-214 branch from 0b480ec to 5e161f2 Jun 29, 2019

@ipdae ipdae force-pushed the ipdae:bugfix/issues-214 branch from 5e161f2 to a894475 Jun 29, 2019

@dahlia

dahlia approved these changes Jun 29, 2019

@dahlia dahlia requested a review from longfin Jun 29, 2019

@longfin longfin merged commit 7e18f34 into planetarium:master Jun 29, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 100% of diff hit (target 87.36%)
Details
codecov/project 87.37% (+<.01%) compared to a82d2f2
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190629.26 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.