Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Swarm constructor have BlockChain<T> #324

Merged
merged 3 commits into from Jul 3, 2019

Conversation

Projects
None yet
3 participants
@earlbread
Copy link
Member

commented Jul 3, 2019

This makes Swarm constructor receive BlockChain<T> and have a type parameter T.

@earlbread earlbread added this to the 0.4.0 milestone Jul 3, 2019

@earlbread earlbread requested review from dahlia and longfin Jul 3, 2019

@earlbread earlbread self-assigned this Jul 3, 2019

Show resolved Hide resolved CHANGES.md Outdated
@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #324 into master will decrease coverage by 0.1%.
The diff coverage is 87.57%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   87.39%   87.28%   -0.11%     
==========================================
  Files         189      189              
  Lines       12744    12769      +25     
==========================================
+ Hits        11137    11145       +8     
- Misses       1355     1374      +19     
+ Partials      252      250       -2
Impacted Files Coverage Δ
Libplanet/Net/DifferentProtocolVersionEventArgs.cs 100% <ø> (ø) ⬆️
...planet/Net/DifferentAppProtocolVersionException.cs 75% <ø> (ø) ⬆️
Libplanet/Net/Peer.cs 92.72% <ø> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 91.29% <86.61%> (-2.47%) ⬇️
Libplanet/Net/Swarm.cs 74.88% <91.42%> (-0.01%) ⬇️
Libplanet/Crypto/PrivateKey.cs 85.58% <0%> (+0.9%) ⬆️

@earlbread earlbread force-pushed the earlbread:swarm-blockchain2 branch from 40768b2 to 55db2e0 Jul 3, 2019

Show resolved Hide resolved CHANGES.md Outdated

@dahlia dahlia changed the title Make Swarm have BlockChain<T> Make Swarm constructor have BlockChain<T> Jul 3, 2019

@earlbread earlbread force-pushed the earlbread:swarm-blockchain2 branch 2 times, most recently from 894a900 to 395299b Jul 3, 2019

Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved CHANGES.md Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
Show resolved Hide resolved Libplanet/Net/Swarm.cs Outdated
@codecov

This comment has been minimized.

Copy link

commented Jul 3, 2019

Codecov Report

Merging #324 into master will decrease coverage by 0.04%.
The diff coverage is 87.57%.

@@            Coverage Diff             @@
##           master     #324      +/-   ##
==========================================
- Coverage   87.39%   87.34%   -0.05%     
==========================================
  Files         189      189              
  Lines       12744    12767      +23     
==========================================
+ Hits        11137    11151      +14     
- Misses       1355     1366      +11     
+ Partials      252      250       -2
Impacted Files Coverage Δ
Libplanet/Net/DifferentProtocolVersionEventArgs.cs 100% <ø> (ø) ⬆️
...planet/Net/DifferentAppProtocolVersionException.cs 75% <ø> (ø) ⬆️
Libplanet/Net/Peer.cs 92.72% <ø> (ø) ⬆️
Libplanet.Tests/Net/SwarmTest.cs 92.34% <86.61%> (-1.42%) ⬇️
Libplanet/Net/Swarm.cs 74.84% <91.42%> (-0.04%) ⬇️
Libplanet/Crypto/PrivateKey.cs 85.58% <0%> (+0.9%) ⬆️

earlbread and others added some commits Jun 19, 2019

Elaborate description for type parameter
Co-Authored-By: Swen Mun <longfinfunnel@gmail.com>
Reword docs
Co-Authored-By: Hong Minhee <hong.minhee@gmail.com>

@earlbread earlbread force-pushed the earlbread:swarm-blockchain2 branch from 9c8b25d to ee7ce65 Jul 3, 2019

@earlbread

This comment has been minimized.

Copy link
Member Author

commented Jul 3, 2019

Applied review comments. Please take a look.

@dahlia

dahlia approved these changes Jul 3, 2019

@longfin

longfin approved these changes Jul 3, 2019

@earlbread earlbread merged commit 5e554ca into planetarium:master Jul 3, 2019

16 checks passed

WIP Ready for review
Details
changelog This contains self-describing changelog.
Details
codecov/patch 87.57% of diff hit (target 87.39%)
Details
codecov/project Absolute coverage decreased by -0.04% but relative coverage increased by +0.18% compared to dce3bbf
Details
docs Libplanet docs generated by DocFX
Details
license/cla Contributor License Agreement is signed.
Details
planetarium.libplanet Build #20190703.8 succeeded
Details
planetarium.libplanet (Linux_Mono) Linux_Mono succeeded
Details
planetarium.libplanet (Linux_NETCore) Linux_NETCore succeeded
Details
planetarium.libplanet (Windows_Mono) Windows_Mono succeeded
Details
planetarium.libplanet (Windows_NETCore) Windows_NETCore succeeded
Details
planetarium.libplanet (Windows_NETCore_coverage) Windows_NETCore_coverage succeeded
Details
planetarium.libplanet (Windows_NETFramework) Windows_NETFramework succeeded
Details
planetarium.libplanet (macOS_Mono) macOS_Mono succeeded
Details
planetarium.libplanet (macOS_NETCore) macOS_NETCore succeeded
Details
planetarium.libplanet (macOS_Unity) macOS_Unity succeeded
Details

@earlbread earlbread deleted the earlbread:swarm-blockchain2 branch Jul 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.